Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Device log changes #4916

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Revert Device log changes #4916

merged 2 commits into from
Dec 13, 2024

Conversation

hardillb
Copy link
Contributor

Description

Revert to allow multiple users to view the device log

Related Issue(s)

#4832

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.70%. Comparing base (d325765) to head (d30cdfa).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4916   +/-   ##
=======================================
  Coverage   78.70%   78.70%           
=======================================
  Files         323      323           
  Lines       15231    15231           
  Branches     3498     3498           
=======================================
  Hits        11988    11988           
  Misses       3243     3243           
Flag Coverage Δ
backend 78.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having reviewed the original changes in #4893, I agree this partial code revert is sufficient to revert the behaviour.

@knolleary knolleary merged commit 6bdabe5 into main Dec 13, 2024
18 checks passed
@knolleary knolleary deleted the revert-device-log-disconnect branch December 13, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants