Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an import library is treated as a static library on OS/2 #1321

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

derselbst
Copy link
Member

On OS/2, a suffix of an import library is '_dll.a', and a suffix of a static library is '.a'.

Because of this, an import library is treated as a static library in get_target_properties_from_pkg_config().

On OS/2, a suffix of an import library is '_dll.a', and a suffix of
a static library is '.a'.

Because of this, an import library is treated as a static library in
get_target_properties_from_pkg_config().
@derselbst derselbst linked an issue Apr 23, 2024 that may be closed by this pull request
@derselbst derselbst added this to the 2.3 milestone Apr 23, 2024
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@derselbst derselbst merged commit 2bb9d83 into release/2.3 Apr 23, 2024
58 of 67 checks passed
@derselbst derselbst deleted the issue1320 branch April 23, 2024 20:59
DominusExult added a commit to DominusExult/fluidsynth-sans-glib that referenced this pull request Jul 29, 2024
* master: (33 commits)
  Remove interpolation of IIR filter coefficients (FluidSynth#1345)
  Add OS/2 KAI audio driver
  Fix behavior of volume envelope delay phase
  Fix chorus when compiling with single precision (FluidSynth#1339)
  Update docs about XG bank selection logic
  Fix a few compiler warnings
  Fix linkage against gobject
  Fix mixed declaration
  Log NRPNs in verbose mode
  Update documentation of synth.device-id
  Access to synth->bank_select not guarded by mutex
  when processing command line options: -o setting=value, the value is converted to UTF8
  review findings
  Documentation updated (settings, about utf-8 encoding) C++ example updated
  drivers: winmidi,waveout and dsound using utf8 options Unicode support enabled in CMake script and CLI utility
  Fixed  wasapi driver; encode device names as CP_UTF8 Solves FluidSynth#1322
  Fix an import library is treated as a static library on OS/2 (FluidSynth#1321)
  Bump the github-actions group with 2 updates
  Keep GitHub Actions up to date with GitHub's Dependabot
  Minor fixups for MSYS2 CI (FluidSynth#1317)
  ...

# Conflicts:
#	CMakeLists.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix an import library is treated as a static library on OS/2
2 participants