Fix chorus when compiling with single precision #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello Tom, I'm afraid this change won't be enough. For detail, please read my comment in issue #1331. |
|
DominusExult
added a commit
to DominusExult/fluidsynth-sans-glib
that referenced
this pull request
Jul 29, 2024
* master: (33 commits) Remove interpolation of IIR filter coefficients (FluidSynth#1345) Add OS/2 KAI audio driver Fix behavior of volume envelope delay phase Fix chorus when compiling with single precision (FluidSynth#1339) Update docs about XG bank selection logic Fix a few compiler warnings Fix linkage against gobject Fix mixed declaration Log NRPNs in verbose mode Update documentation of synth.device-id Access to synth->bank_select not guarded by mutex when processing command line options: -o setting=value, the value is converted to UTF8 review findings Documentation updated (settings, about utf-8 encoding) C++ example updated drivers: winmidi,waveout and dsound using utf8 options Unicode support enabled in CMake script and CLI utility Fixed wasapi driver; encode device names as CP_UTF8 Solves FluidSynth#1322 Fix an import library is treated as a static library on OS/2 (FluidSynth#1321) Bump the github-actions group with 2 updates Keep GitHub Actions up to date with GitHub's Dependabot Minor fixups for MSYS2 CI (FluidSynth#1317) ... # Conflicts: # CMakeLists.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default chorus parameters yield an oscillator phase close to PI/2. When compiling with single precision, the phase becomes exactly PI/2, which causes the sinusoidal oscillation to get stuck, causing attenuated signals on the left or right channels, see #1331.
This only avoids a phase of PI/2 for the default values. I.e. it doesn't fix the chorus behavior when the phase really evaluates equal to PI/2.