Remove default SvgTheme argument preventing DefaultSvgTheme works…

… correctly (#485)

The default SvgTheme argument prevents `DefaultSvgTheme` provider works
correctly. This should be null and works as a passthrough behavior

## What does this change?

Remove default `SvgTheme` from svg generator

Fixes #484 🎯

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)

CONTRIBUTING.md

@@ -32,7 +32,7 @@ $ dart packages/command/bin/flutter_gen_command.dart --config example/pubspec.ya
 
 Or melos
 ```sh
-$ melos gen:example:command
+$ melos gen:examples:command
 ```
 
 #### Use as part of build_runner

examples/example/lib/gen/assets.gen.dart

@@ -292,7 +292,7 @@ class SvgGenImage {
     WidgetBuilder? placeholderBuilder,
     String? semanticsLabel,
     bool excludeFromSemantics = false,
-    SvgTheme theme = const SvgTheme(),
+    SvgTheme? theme,
     ColorFilter? colorFilter,
     Clip clipBehavior = Clip.hardEdge,
     @deprecated Color? color,

examples/example/pubspec.yaml

@@ -22,6 +22,8 @@ dev_dependencies:
   lints: ^2.0.0
   build_runner: ^2.0.0
   flutter_gen_runner: ^5.4.0
+  flutter_test:
+    sdk: flutter
 
 flutter_gen:
   output: lib/gen/ # Optional (default: lib/gen/)

examples/example/test/svg_integrations_test.dart

@@ -0,0 +1,53 @@
+@TestOn('vm')
+import 'package:example/gen/assets.gen.dart';
+import 'package:flutter/material.dart';
+import 'package:flutter_svg/flutter_svg.dart';
+import 'package:flutter_test/flutter_test.dart';
+
+class SvgIntegrationsTest extends StatelessWidget {
+  const SvgIntegrationsTest({required this.theme});
+
+  final SvgTheme theme;
+
+  @override
+  Widget build(BuildContext context) {
+    return DefaultSvgTheme(
+      theme: theme,
+      child: MyAssets.images.icons.dartTest.svg(),
+    );
+  }
+}
+
+void main() {
+  group('Test SvgTheme behavior', () {
+    var testTheme = SvgTheme(currentColor: Colors.red);
+
+    testWidgets('Passed theme should be null', (widgetTester) async {
+      await widgetTester.pumpWidget(SvgIntegrationsTest(theme: testTheme));
+
+      var finder = find.byType(SvgPicture);
+      expect(finder, findsOneWidget);
+
+      var svgWidget = widgetTester.widget<SvgPicture>(finder);
+      var loader = svgWidget.bytesLoader as SvgAssetLoader;
+
+      expect(loader.theme, isNull);
+    });
+
+    testWidgets(
+        'Taken theme of SvgAssetLoader equals with one passed to parent DefaultSvgTheme',
+        (widgetTester) async {
+      await widgetTester.pumpWidget(SvgIntegrationsTest(theme: testTheme));
+
+      var finder = find.byType(SvgPicture);
+      expect(finder, findsOneWidget);
+
+      var svgWidget = widgetTester.widget<SvgPicture>(finder);
+      var loader = svgWidget.bytesLoader as SvgAssetLoader;
+
+      var svgCacheKey = loader.cacheKey(widgetTester.element(finder));
+
+      expect(svgCacheKey.theme, testTheme);
+    });
+  });
+}

examples/example_resources/lib/gen/assets.gen.dart

@@ -153,7 +153,7 @@ class SvgGenImage {
     WidgetBuilder? placeholderBuilder,
     String? semanticsLabel,
     bool excludeFromSemantics = false,
-    SvgTheme theme = const SvgTheme(),
+    SvgTheme? theme,
     ColorFilter? colorFilter,
     Clip clipBehavior = Clip.hardEdge,
     @deprecated Color? color,

melos.yaml

@@ -69,8 +69,8 @@ scripts:
     description: flutter pub run build_runner build --delete-conflicting-outputs
 
   test:
-    run: melos test:dart --no-select
-    description: dart test
+    run: melos test:dart --no-select && melos test:flutter --no-select
+    description: dart & flutter test
 
   test:dart:
     run: dart test
@@ -81,6 +81,15 @@ scripts:
       dependsOn: test
     description: dart test
 
+  test:flutter:
+    run: flutter test
+    exec:
+      failFast: true
+    packageFilters:
+      flutter: true
+      dependsOn: flutter_test
+    description: flutter test
+
   coverage:
     run: |
       bash ./scripts/coverage.sh packages/core

packages/core/lib/generators/integrations/svg_integration.dart

@@ -42,7 +42,7 @@ ${isPackage ? "\n  static const String package = '$packageName';" : ''}
     WidgetBuilder? placeholderBuilder,
     String? semanticsLabel,
     bool excludeFromSemantics = false,
-    SvgTheme theme = const SvgTheme(),
+    SvgTheme? theme,
     ColorFilter? colorFilter,
     Clip clipBehavior = Clip.hardEdge,
     @deprecated Color? color,