Remove default SvgTheme argument preventing DefaultSvgTheme works correctly

[mym0404]

The default SvgTheme argument prevents DefaultSvgTheme provider works correctly. This should be null and works as passthrough behavior

What does this change?

Remove default SvgTheme from svg generator

Fixes #484 🎯

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist:

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

• Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests (melos run test)
  • Ensure the analyzer and formatter pass (melos run format to automatically apply formatting)
• Appropriate docs were updated (if necessary)

Result

I can confirm that it works after patch this.

  flutter_gen_runner:
    git:
      url: https://github.com/mym0404/flutter_gen.git
      path: packages/runner
      ref: core-patched

[AlexV525]

Thanks for the contribution, could you also add tests indicate that DefaultSvgTheme works?

[mym0404]

@AlexV525 Do you mean we should add flutter and flutter_test dev dependencies into core package? or should we set up test in example?

---

I added test at example project.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (b45112b) to head (25f921b).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #485   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files          21       21           
  Lines         730      730           
=======================================
  Hits          718      718           
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AlexV525]

The fix looks good so far!