Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dark mode version of logo #2063

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Conversation

Saransh-cpp
Copy link
Member

  • dark mode version of logo
  • no sidebar title
  • dynamic rendering of dark/light logo in the README file

See FluxML/Zygote.jl#1306

image

image

The white Flux logo looks a bit weird to me, but maybe because I am used to seeing the black Flux logo?

PR Checklist

  • Tests are added
  • Entry in NEWS.md
  • Documentation, if applicable

@darsnack
Copy link
Member

Maybe a white outline on the arrow is better than a totally white arrow?

@ToucheSir
Copy link
Member

Maybe a white outline on the arrow is better than a totally white arrow?

I concur. At the very least, it would be nice to have distinct shades for the arrow and outline.

@mcabbott
Copy link
Member

Shall we try this out? Seems like a step forwards.

I'm not too sure how @Saransh-cpp made this, but I guess replacing a colour is easier than adding new borders of a different colour.

@mcabbott mcabbott merged commit 1797f2a into FluxML:master Sep 27, 2022
@Saransh-cpp
Copy link
Member Author

Saransh-cpp commented Sep 27, 2022

I guess replacing a colour is easier than adding new borders of a different colour.

Yes! It took me some time (not a graphic designer 😬), but here are the designs (see them in GitHub's dark mode) -

(I don't have a very strong preference in this matter. Which one should go in?)

IMG_0616
IMG_0620

@Saransh-cpp Saransh-cpp deleted the dark-logo branch September 27, 2022 14:11
@Saransh-cpp
Copy link
Member Author

Note: The arrow in current Flux logo has a greyish outline.

@mcabbott
Copy link
Member

I actually think this looks fine. Maybe there's a design where the text & arrow have boundaries like the "layers" do, but this sounds like a lot of work, and not immediately obvious it would be better. I think you'd still want the bulk of the text white (in dark mode) to match the other text.

Before this PR:
Screenshot 2022-09-27 at 10 13 05

After:
Screenshot 2022-09-27 at 10 12 52Screenshot 2022-09-27 at 10 15 06

@Saransh-cpp
Copy link
Member Author

conda-forge does something similar with their logo, but the current one looks good to me as well -

image
image
image

@Saransh-cpp
Copy link
Member Author

Also, now that I look at it, maybe we should always use the old logo in README? Flux uses the old logo everywhere (for example - FluxML's GitHub logo/display picture), and most of them cannot be made dynamic.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants