Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Zygote's logo a real PNG #1306

Merged
merged 4 commits into from
Sep 21, 2022
Merged

Make Zygote's logo a real PNG #1306

merged 4 commits into from
Sep 21, 2022

Conversation

Saransh-cpp
Copy link
Member

Looks much better now! (like Flux's logo)

I couldn't push to a new branch in Zygote (access issues) for the docs preview to work, but here is how this looks (in the sidebar) -

Before

image
image

After

image
image

@mcabbott
Copy link
Member

Thanks!

Is there an easy way to make the black text more visible in dark mode, here and in Flux? Maybe the side-bar should be a lighter shade (and darker, in the light theme)?

(And should we remove the text Zygote below the logo, seems a bit repetitive?)

@Saransh-cpp
Copy link
Member Author

Saransh-cpp commented Sep 21, 2022

image

image

Much better now!

Should I do the same with Flux's logo as well?

Copy link
Member

@mcabbott mcabbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks perfect! And sure, Flux too, why not?

@mcabbott mcabbott merged commit 47a9002 into FluxML:master Sep 21, 2022
@Saransh-cpp Saransh-cpp deleted the logo branch September 21, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants