Improvement/functional primitives #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore(lodash): Update to version 4.17.15 (npm advisory 1065)
fix scroll wheel interaction in chrome
fix createContainer with zoom and voronai - props ends up undefined at line 69 and throws an error "props.events - can't get events of undefined"
Update victory-container.js
fix error on createContainer with zoom and vonoroi
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors all primitives to use stateless functional components instead of classes. Base primitives like
PathuseReact.memowithisEqualfromreact-fast-compareinstead ofsCUlogic. This PR is a breaking change forvictory-nativeand users who were extending from Victory's primitive components.