Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V33.0.0 #1372

Merged
merged 66 commits into from
Aug 22, 2019
Merged

V33.0.0 #1372

merged 66 commits into from
Aug 22, 2019

Conversation

boygirl
Copy link
Contributor

@boygirl boygirl commented Aug 21, 2019

This PR includes all the changes that will become victory@33.0.0. This PR includes the following PRs:

#1295 - More granular labels for VictoryCandlestick

#1371 - A whole bunch of improvements for VictoryTooltip and targeting integration in VictoryVoronoiContainer, and some minor additional tweaks to VictoryLabel

#1360 - A breaking change for functional props and styles. Instead of datum and active as arguments, functional props will now receive a full set of the props that define the element they correspond to (i.e. index, datum, data, scale, etc)

#1365 - Swapped out React component primitives (Bar, Path etc) with shouldComponentUpdate logic for function primitives. (This is a breaking change for anyone extending from victory components, i.e. victory-native)

#1373 - Some additional improvements specifically targeting victory-native. The only noticeable change here is that invisible and non-event-having gridlines and ticks in VictoryAxis and VictoryPolarAxis are now filtered out rather than rendered.

@boygirl boygirl merged commit bf2cf50 into master Aug 22, 2019
@boygirl boygirl deleted the v33.0.0 branch August 22, 2019 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant