-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V33.0.0 #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add diff labels and orientation support
Improvement/functional-props
…ents Feature/tooltip improvements
Improvements for native
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes all the changes that will become
victory@33.0.0
. This PR includes the following PRs:#1295 - More granular labels for
VictoryCandlestick
#1371 - A whole bunch of improvements for
VictoryTooltip
and targeting integration inVictoryVoronoiContainer
, and some minor additional tweaks toVictoryLabel
#1360 - A breaking change for functional props and styles. Instead of
datum
andactive
as arguments, functional props will now receive a full set of the props that define the element they correspond to (i.e.index
,datum
,data
,scale
, etc)#1365 - Swapped out React component primitives (
Bar
,Path
etc) withshouldComponentUpdate
logic for function primitives. (This is a breaking change for anyone extending fromvictory
components, i.e.victory-native
)#1373 - Some additional improvements specifically targeting
victory-native
. The only noticeable change here is that invisible and non-event-having gridlines and ticks inVictoryAxis
andVictoryPolarAxis
are now filtered out rather than rendered.