-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update watch page to stop at end of playlist (when loop disabled) without countdown #3362
Update watch page to stop at end of playlist (when loop disabled) without countdown #3362
Conversation
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Co-authored-by: absidue <48293849+absidue@users.noreply.github.com>
12bfa58
to
b48c3af
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
You have spotted a 3 year old bug o_0 Fixed & rebased due to merge conflict https://github.com/FreeTubeApp/FreeTube/blame/f94d8a9df257ba3ac78feddc038a3ebebebe4c08/src/renderer/components/watch-video-playlist/watch-video-playlist.js#L208-L210 |
Pull Request Type
Related issue
N/A
Description
Found it weird to see countdown at the end of playlist before seeing "The playlist has ended"
This PR makes it shows that message immediately without countdown
Countdown unchanged when loop enabled/playlist not ended
Screenshots
Testing
Matrix A x B x C
A
B
C
Only these combinations should show "The playlist has ended" immediately
Desktop
Additional context