-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch back to the original behat/mink-browserkit-driver
#195
Switch back to the original behat/mink-browserkit-driver
#195
Conversation
@stof your 👀 and opinion would be very much appreciated. Regarding Psalm errors, I think the root cause is a pending docblock – see minkphp/MinkBrowserKitDriver#166. We probably need that fixed and released before we can continue here. |
|
87b01f0
to
9c7de27
Compare
Converted to draft to prevent accidental merges until necessary changes have been merged elsewhere. |
for the Behat MinkExtension, the goal is indeed for the FriendsOfBehat one to be the replacement. But switching back is the way to go for Mink drivers (btw, if you want to help maintaining Mink, we could welcome new maintainers there instead of forking drivers) |
@mpdude any chance to finish this work ? |
e9df318
to
04cffaa
Compare
04cffaa
to
13a43d1
Compare
This builds upon the suggestion in #187.
If I get it right,
friends-of-behat/mink-browserkit-driver
was a fork of the originalbehat/mink-browserkit-driver
at a time where the original repo was lagging behind in terms of PHP and Symfony version support.It seems the original is now being maintained again, so we should recommend switching back – especially since the FriendsOfBehat version says:
#SymfonyHackday