Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to the original behat/mink-browserkit-driver #195

Merged
merged 2 commits into from
Dec 9, 2023

Conversation

mpdude
Copy link
Contributor

@mpdude mpdude commented Nov 28, 2022

This builds upon the suggestion in #187.

If I get it right, friends-of-behat/mink-browserkit-driver was a fork of the original behat/mink-browserkit-driver at a time where the original repo was lagging behind in terms of PHP and Symfony version support.

It seems the original is now being maintained again, so we should recommend switching back – especially since the FriendsOfBehat version says:

No updates other than Symfony compatibility will be provided, but this fork might be synchronised with the original repository in the future.

#SymfonyHackday

@mpdude
Copy link
Contributor Author

mpdude commented Nov 28, 2022

@stof your 👀 and opinion would be very much appreciated.

Regarding Psalm errors, I think the root cause is a pending docblock – see minkphp/MinkBrowserKitDriver#166.

We probably need that fixed and released before we can continue here.

@mpdude
Copy link
Contributor Author

mpdude commented Nov 28, 2022

What about https://github.com/FriendsOfBehat/MinkExtension vs. https://github.com/Behat/MinkExtension, is that also something we /(sh|c)ould/ switch back? No, Behat/MinkExtension seems to be abandoned. Behat/MinkExtension#370.

@mpdude
Copy link
Contributor Author

mpdude commented Nov 28, 2022

Converted to draft to prevent accidental merges until necessary changes have been merged elsewhere.

@stof
Copy link
Contributor

stof commented Nov 28, 2022

for the Behat MinkExtension, the goal is indeed for the FriendsOfBehat one to be the replacement. But switching back is the way to go for Mink drivers (btw, if you want to help maintaining Mink, we could welcome new maintainers there instead of forking drivers)

@stof
Copy link
Contributor

stof commented Jun 22, 2023

@mpdude any chance to finish this work ?

@lchrusciel lchrusciel marked this pull request as ready for review December 9, 2023 11:00
@lchrusciel lchrusciel closed this Dec 9, 2023
@lchrusciel lchrusciel reopened this Dec 9, 2023
@lchrusciel lchrusciel closed this Dec 9, 2023
@lchrusciel lchrusciel reopened this Dec 9, 2023
@lchrusciel lchrusciel self-assigned this Dec 9, 2023
@lchrusciel lchrusciel closed this Dec 9, 2023
@lchrusciel lchrusciel reopened this Dec 9, 2023
@lchrusciel lchrusciel force-pushed the official-mink-browserkit branch from e9df318 to 04cffaa Compare December 9, 2023 11:52
@lchrusciel lchrusciel force-pushed the official-mink-browserkit branch from 04cffaa to 13a43d1 Compare December 9, 2023 12:02
@lchrusciel lchrusciel merged commit 957df89 into FriendsOfBehat:master Dec 9, 2023
12 checks passed
@lchrusciel
Copy link
Member

Thanks @mpdude and @stof for cooperation! 🎉

@mpdude mpdude deleted the official-mink-browserkit branch December 9, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants