Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to the original behat/mink-browserkit-driver #195

Merged
merged 2 commits into from
Dec 9, 2023
Merged

Switch back to the original behat/mink-browserkit-driver #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c7de27
Switch back to the original `behat/mink-browserkit-driver`
mpdude Nov 28, 2022
13a43d1
[Maintenance] Migrate to official Mink distribution
lchrusciel Dec 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DOCUMENTATION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ isolated driver to use for Symfony application testing.
1. Require the packages needed for the driver using _Composer_:

```bash
composer require --dev friends-of-behat/mink friends-of-behat/mink-extension friends-of-behat/mink-browserkit-driver
composer require --dev behat/mink friends-of-behat/mink-extension behat/mink-browserkit-driver
```

_Those `friends-of-behat` packages are forks of the original ones, adding support for Symfony 5 and dropping support for Symfony <4.4._
Expand Down
8 changes: 4 additions & 4 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
"symfony/proxy-manager-bridge": "^4.4 || ^5.3 || ^6.0"
},
"require-dev": {
"behat/mink-browserkit-driver": "^2.0",
"behat/mink-selenium2-driver": "^1.3",
"friends-of-behat/mink": "^1.9",
"friends-of-behat/mink-browserkit-driver": "^1.5",
"behat/mink": "^1.9",
"friends-of-behat/mink-extension": "^2.5",
"friends-of-behat/page-object-extension": "^0.3.2",
"friends-of-behat/service-container-extension": "^1.1",
Expand All @@ -32,8 +32,8 @@
"vimeo/psalm": "4.15.0"
},
"suggest": {
"friends-of-behat/mink": "^1.9",
"friends-of-behat/mink-browserkit-driver": "^1.5",
"behat/mink-browserkit-driver": "^2.0",
"behat/mink": "^1.9",
"friends-of-behat/mink-extension": "^2.5"
},
"config": {
Expand Down
2 changes: 1 addition & 1 deletion src/Driver/Factory/SymfonyDriverFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public function configure(ArrayNodeDefinition $builder): void
public function buildDriver(array $config): Definition
{
if (!class_exists(BrowserKitDriver::class)) {
throw new \RuntimeException('Install "friends-of-behat/mink-browserkit-driver" (drop-in replacement for "behat/mink-browserkit-driver") in order to use the "symfony" driver.');
throw new \RuntimeException('Install "behat/mink-browserkit-driver" in order to use the "symfony" driver.');
}

return new Definition(SymfonyDriver::class, [
Expand Down