Merge pull request #11 from FuelRats/v2.2-adjustments

.vscode/settings.json

@@ -3,5 +3,6 @@
     { "directory": "./eslint-config", "changeProcessCWD": true },
     { "directory": "./eslint-config-react", "changeProcessCWD": true }
   ],
+  "editor.rulers": [180],
   "git.ignoreLimitWarning": true
 }

package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-fuelrats",
-  "version": "2.1.0",
+  "version": "2.2.0",
   "description": "Monorepo for @fuelrats/eslint-config[-react]!",
   "private": true,
   "license": "MIT",
@@ -37,7 +37,7 @@
   "workspaces": [
     "packages/*"
   ],
-  "main": "./packages/eslint-config-react/develop.js",
+  "main": "./packages/eslint-config/index.js",
   "scripts": {
     "eslint": "yarn workspaces run eslint .",
     "release:base": "yarn workspace @fuelrats/eslint-config run release",
@@ -48,15 +48,18 @@
     "release:canary": "yarn workspaces run release:canary",
     "autoversion": "bash ./scripts/autoversion.sh"
   },
+  "dependencies": {
+    "eslint-restricted-globals": "^0.2.0"
+  },
   "devDependencies": {
-    "babel-eslint": "^10.0.3",
-    "eslint": "^6.8.0",
-    "eslint-plugin-babel": "^5.3.0",
-    "eslint-plugin-import": "^2.20.0",
-    "eslint-plugin-jsdoc": "^21.0.0",
-    "eslint-plugin-jsx-a11y": "^6.2.3",
-    "eslint-plugin-react": "^7.18.0",
-    "eslint-plugin-react-hooks": "^2.3.0",
-    "react": "^16.12.0"
+    "babel-eslint": "^10.1.0",
+    "eslint": "^7.5.0",
+    "eslint-plugin-babel": "^5.3.1",
+    "eslint-plugin-import": "^2.22.0",
+    "eslint-plugin-jsdoc": "^30.0.0",
+    "eslint-plugin-jsx-a11y": "^6.3.1",
+    "eslint-plugin-react": "^7.20.3",
+    "eslint-plugin-react-hooks": "^4.0.8",
+    "react": "^16.13.1"
   }
 }

packages/eslint-config-react/CHANGELOG.md

@@ -1,7 +1,20 @@
 # @fuelrats/eslint-config-react Changelog
 
 
-## Unreleased
+### Unreleased
+
+#### Additions
+* Enable `jsx-a11y/autocomplete-valid`
+
+
+#### Changes
+* set `parser` and `parserOptions` from main package so `eslint-config-react` can be used standalone.
+
+
+#### Fixed
+* resolved an issue where `indent` and `react/jsx-indent` conflict.
+
+
 
 
 

packages/eslint-config-react/index.js

@@ -13,10 +13,13 @@ module.exports = {
     './rules/plugin-react-hooks',
     './rules/plugin-jsx-a11y',
   ].map(require.resolve),
+  parser: 'babel-eslint',
   parserOptions: {
     ecmaFeatures: {
       jsx: true,
     },
+    ecmaVersion: 2020,
+    sourceType: 'module',
   },
   settings: {
     react: {

packages/eslint-config-react/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fuelrats/eslint-config-react",
-  "version": "2.1.0",
+  "version": "2.2.0",
   "description": "ESLint config for fuelrats react projects",
   "license": "MIT",
   "author": {
@@ -49,21 +49,22 @@
     "release:canary": "yarn publish --tag canary --non-interactive"
   },
   "devDependencies": {
-    "babel-eslint": "^10.0.3",
-    "eslint": "^6.8.0",
-    "eslint-plugin-babel": "^5.3.0",
-    "eslint-plugin-import": "^2.20.0",
-    "eslint-plugin-jsdoc": "^21.0.0",
-    "eslint-plugin-jsx-a11y": "^6.2.3",
-    "eslint-plugin-react": "^7.18.0",
-    "eslint-plugin-react-hooks": "^2.3.0",
-    "react": "^16.12.0"
+    "babel-eslint": "^10.1.0",
+    "eslint": "^7.5.0",
+    "eslint-plugin-babel": "^5.3.1",
+    "eslint-plugin-import": "^2.22.0",
+    "eslint-plugin-jsdoc": "^30.0.0",
+    "eslint-plugin-jsx-a11y": "^6.3.1",
+    "eslint-plugin-react": "^7.20.3",
+    "eslint-plugin-react-hooks": "^4.0.8",
+    "react": "^16.13.1"
   },
   "peerDependencies": {
-    "eslint": ">=6.7",
-    "eslint-plugin-jsx-a11y": ">=6.2",
-    "eslint-plugin-react": ">=7.18",
-    "eslint-plugin-react-hooks": ">=2.3",
-    "react": ">=16.8"
+    "babel-eslint": "^10",
+    "eslint": "^7.5",
+    "eslint-plugin-jsx-a11y": "^6.3",
+    "eslint-plugin-react": "^7.20",
+    "eslint-plugin-react-hooks": "^4.0.1",
+    "react": "^16.8"
   }
 }

packages/eslint-config-react/rules/plugin-jsx-a11y.js

@@ -67,6 +67,12 @@ module.exports = {
     'jsx-a11y/aria-unsupported-elements': ['error'],
 
 
+    /**
+     * Enforce that autocomplete attributes are used correctly.
+     */
+    'jsx-a11y/autocomplete-valid': ['error'],
+
+
     /**
      * Enforce a clickable non-interactive element has at least one keyboard event listener.
      */

packages/eslint-config-react/rules/plugin-next.js

@@ -0,0 +1,12 @@
+module.exports = {
+  plugins: [
+    'next',
+  ],
+  rules: {
+    'next/no-css-tags': ['error'],
+
+    'next/no-html-link-for-pages': ['error'],
+
+    'next/no-sync-scripts': ['error'],
+  },
+}

packages/eslint-config-react/rules/plugin-react-jsx.js

@@ -87,7 +87,7 @@ module.exports = {
      * Validate JSX indentation (fixable)
      */
     'react/jsx-indent': ['error', 2, {
-      checkAttributes: true,
+      checkAttributes: false,
       indentLogicalExpressions: true,
     }],
 

packages/eslint-config-react/rules/plugin-react.js

@@ -326,7 +326,7 @@ module.exports = {
     /**
      * Enforce where React component static properties should be positioned.
      */
-    'react/static-property-placement': ['off'],
+    'react/static-property-placement': ['error', 'static public field'],
 
 
     /**

packages/eslint-config/.eslintrc.js

@@ -10,7 +10,7 @@ module.exports = {
   extends: './index.js',
   rules: {
     'no-magic-numbers': ['off'], // since defining a bunch of consts for lint rules is cumbersome
-    'quote-props': ['error', 'consistent-as-needed'], // since the majority of rules are in quotes with little outlyers;
+    'quote-props': ['error', 'consistent-as-needed'], // since the majority of rules are in quotes with little outliers;
     'max-lines': ['off'], // We're not interested in breaking up rule files
-  }
+  },
 }

packages/eslint-config/CHANGELOG.md

@@ -1,8 +1,29 @@
 # @fuelrats/eslint-config Changelog
 
 
-## Unreleased
+### Unreleased
 
+#### Additions
+* Warn when a lint rule is being disabled that doesn't need to be.
+* Enable ESLint v7 rules
+  * `default-case-last`
+  * `no-useless-backreference`
+  * `no-promise-executor-return`
+  * `no-unreachable-loop`
+* Recognize the path alias `~` as an `internal` import in import ordering.
+
+
+#### Changes
+* Better and more consistent restricted syntax messages.
+* Disallow explicit null checks via `no-restricted syntax` instead of abusing the combination of `eqeqeq`'s null option and `no-eq-null`
+* add `inheritdoc` to certain `jsdoc` rule `exemptedBy` options so it's consistent with the default config
+* make `import/order` case insensitive sort.
+* Remove all node-specific rules since they are now deprecated.
+* Improved settings for import plugin.
+* Use `id-denylist` over `id-blacklist`
+  * Even though this rule is off we'd rather not have deprecated rule names :D
+* Ensure our config is JSON serializable by replacing `Infinity` with `Number.MAX_SAFE_INTEGER`
+* Enable `ignoreGlobals` for `camelcase` rule
 
 
 ### 2.1.0

packages/eslint-config/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fuelrats/eslint-config",
-  "version": "2.1.0",
+  "version": "2.2.0",
   "description": "ESLint config for fuelrats projects",
   "license": "MIT",
   "author": {
@@ -51,17 +51,20 @@
     "eslint-restricted-globals": "^0.2.0"
   },
   "devDependencies": {
-    "babel-eslint": "^10.0.3",
-    "eslint": "^6.8.0",
-    "eslint-plugin-babel": "^5.3.0",
-    "eslint-plugin-import": "^2.20.0",
-    "eslint-plugin-jsdoc": "^21.0.0"
+    "babel-eslint": "^10.1.0",
+    "eslint": "^7.5.0",
+    "eslint-plugin-babel": "^5.3.1",
+    "eslint-plugin-import": "^2.22.0",
+    "eslint-plugin-jsdoc": "^30.0.0",
+    "eslint-plugin-react": "^7.20.3",
+    "eslint-plugin-react-hooks": "^4.0.8",
+    "react": "^16.13.1"
   },
   "peerDependencies": {
-    "babel-eslint": ">=10",
-    "eslint": ">=6.7",
-    "eslint-plugin-babel": ">=5.3",
-    "eslint-plugin-import": ">=2.19",
-    "eslint-plugin-jsdoc": ">=21.0.0"
+    "babel-eslint": "^10",
+    "eslint": "^7.5",
+    "eslint-plugin-babel": "^5.3",
+    "eslint-plugin-import": "^2.21",
+    "eslint-plugin-jsdoc": "^28 || ^29 || ^30"
   }
 }

packages/eslint-config/purejs.js

@@ -11,7 +11,6 @@ module.exports = {
     './rules/bestpractices',
     './rules/errors',
     './rules/es6',
-    './rules/node',
     './rules/style',
     './rules/variables',
     './rules/plugin-import',

packages/eslint-config/rules/bestpractices.js

@@ -60,6 +60,12 @@ module.exports = {
     }],
 
 
+    /**
+     * enforce default clauses in switch statements to be last
+     */
+    'default-case-last': ['error'],
+
+
     /**
      * enforce default parameters to be last
      */
@@ -82,7 +88,7 @@ module.exports = {
      * require the use of === and !==
      */
     'eqeqeq': ['error', 'always', {
-      null: 'never',
+      null: 'always',
     }],
 
 

packages/eslint-config/rules/errors.js

@@ -61,6 +61,8 @@ module.exports = {
 
     /**
      * disallow the use of debugger
+     *
+     * The impact of debugger slipping into production code HEAVILY outweighs it's benefit.
      */
     'no-debugger': ['error'],
 
@@ -167,6 +169,12 @@ module.exports = {
     'no-obj-calls': ['error'],
 
 
+    /**
+     * disallow returning values from Promise executor functions
+     */
+    'no-promise-executor-return': ['error'],
+
+
     /**
      * disallow calling some Object.prototype methods directly on objects
      */
@@ -209,6 +217,12 @@ module.exports = {
     'no-unreachable': ['error'],
 
 
+    /**
+     * disallow loops with a body that allows only one iteration
+     */
+    'no-unreachable-loop': ['error'],
+
+
     /**
      * disallow control flow statements in finally blocks
      */
@@ -223,6 +237,12 @@ module.exports = {
     }],
 
 
+    /**
+     * disallow useless backreferences in regular expressions
+     */
+    'no-useless-backreference': ['error'],
+
+
     /**
      * disallow assignments that can lead to race conditions due to usage of await or yield
      *

packages/eslint-config/rules/es6.js

@@ -71,6 +71,12 @@ module.exports = {
     'no-new-symbol': ['error'],
 
 
+    /**
+     * disallow specified names in exports
+     */
+    'no-restricted-exports': ['off'],
+
+
     /**
      * disallow specified modules when loaded by import
      *