Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.2 - ESLint v7 #11

Merged
merged 42 commits into from
Jul 19, 2020
Merged

v2.2 - ESLint v7 #11

merged 42 commits into from
Jul 19, 2020

Conversation

UncleClapton
Copy link
Member

@UncleClapton UncleClapton commented May 9, 2020

Base Config

Additions

  • Warn when a lint rule is being disabled that doesn't need to be.
  • Enable ESLint v7 rules
    • default-case-last
    • no-useless-backreference
    • no-promise-executor-return
    • no-unreachable-loop
  • Recognize the path alias ~ as an internal import in import ordering.

Changes

  • Better and more consistent restricted syntax messages.
  • Disallow explicit null checks via no-restricted syntax instead of abusing the combination of eqeqeq's null option and no-eq-null
  • add inheritdoc to certain jsdoc rule exemptedBy options so it's consistent with the default config
  • make import/order case insensitive sort.
  • Remove all node-specific rules since they are now deprecated.
  • Improved settings for import plugin.
  • Use id-denylist over id-blacklist
    • Even though this rule is off we'd rather not have deprecated rule names :D
  • Ensure our config is JSON serializable by replacing Infinity with Number.MAX_SAFE_INTEGER
  • Enable ignoreGlobals for camelcase rule

React Config

Additions

  • Enable jsx-a11y/autocomplete-valid

Changes

  • set parser and parserOptions from main package so eslint-config-react can be used standalone.

Fixed

  • resolved an issue where indent and react/jsx-indent conflict.

@UncleClapton UncleClapton self-assigned this May 9, 2020
@UncleClapton UncleClapton changed the base branch from master to develop May 9, 2020 18:05
@UncleClapton UncleClapton marked this pull request as ready for review July 8, 2020 16:44
SuperManifolds
SuperManifolds previously approved these changes Jul 14, 2020
@UncleClapton
Copy link
Member Author

All that was changed since review was dependency versions. pushing to develop.

@UncleClapton UncleClapton merged commit 1461ec2 into develop Jul 19, 2020
@UncleClapton UncleClapton deleted the v2.2-adjustments branch July 19, 2020 05:40
@UncleClapton UncleClapton mentioned this pull request Jul 19, 2020
@github-actions
Copy link

github-actions bot commented Mar 5, 2023

🎉 This PR is included in version @fuelrats/eslint-config-v1.0.0-canary.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants