fix the landing page #10
Conversation
| @import '../../pages/Landing/components/Footer/Footer.module.scss'; | ||
| @import '../../pages/Landing/components/Section/Section.module.scss'; |
There was a problem hiding this comment.
import these scss files in their own component.
Footer.scss into Footer.jsx and same with the other component. they belong to each other
| width: 100%; | ||
| overflow-x: hidden; |
There was a problem hiding this comment.
our project has a maximim witdh of 128rem.
centered and 128rems
| @@ -286,7 +283,7 @@ | |||
| } | |||
|
|
|||
| body { | |||
| font-family: $font; | |||
| font-family: $font !important; | |||
There was a problem hiding this comment.
try to not to overuse !important ! only when it's strict necessary. here I don't think that is the case
|
|
||
| import Image2 from './images/Image 2.png' | ||
| import Group54 from './images/Group54.png' | ||
| import Group57 from './images/Group57.png' | ||
|
|
||
| const Landing = props => { |
There was a problem hiding this comment.
can you add and the wave effect that is on the template for sections?? you can use css for that
| min-width: 100%; | ||
| height: 100vh; |
There was a problem hiding this comment.
same thing with 128 rems.
| $primary-color: #3b0e8a; | ||
| $primary-color-light: #c698f3; | ||
| $primary-color-light-1: #7c7b7e; | ||
| $primary-color-light-2: #e6e0f2; | ||
|
|
||
| $primary-color-dark: #190934cc; | ||
|
|
||
| $secondary-color: #f16600; | ||
|
|
||
| $background-color-1: #fbf9fd; | ||
| $text-color: #7f75a5; |
There was a problem hiding this comment.
add variables in their own file( not need to create 2 variables files for scss... with the time it will be confusing where and in which file you will store variables)
complete the landing page