Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket page #32

Open
wants to merge 29 commits into
base: real-master
Choose a base branch
from
Open

Ticket page #32

wants to merge 29 commits into from

Conversation

fuelupeducation
Copy link
Contributor

No description provided.

SirPm and others added 26 commits February 4, 2021 15:16
…ed FormProvider, created the popup modals for biometric sign in
…ed FormProvider, created the popup modals for biometric sign in
…or importing the assets and changing them to absolute paths, making the images for the social media icons an array
Revert "coded challenge the sign in pages"
Copy link

@ArchitW ArchitW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall PR looks good to me. Please add colors in the variable and have them in a centralized file to avoid different developers using different colors.
colors
font-sizes
padding
spacing

should be centralized

@ArchitW ArchitW added the Changes Requested Some comments left by reviwer which needs to be addressed by developer label Apr 18, 2021
@ArchitW
Copy link

ArchitW commented Apr 20, 2021

LGTM, Good to merge

@ArchitW ArchitW removed the Changes Requested Some comments left by reviwer which needs to be addressed by developer label Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants