-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ticket page #32
Open
fuelupeducation
wants to merge
29
commits into
real-master
Choose a base branch
from
newbranch
base: real-master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ticket page #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut, select and button component
…ed FormProvider, created the popup modals for biometric sign in
…ut, select and button component
…ed FormProvider, created the popup modals for biometric sign in
… text in form fields
add study group page
…or importing the assets and changing them to absolute paths, making the images for the social media icons an array
coded challenge the sign in pages
Revert "coded challenge the sign in pages"
ArchitW
reviewed
Apr 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall PR looks good to me. Please add colors in the variable and have them in a centralized file to avoid different developers using different colors.
colors
font-sizes
padding
spacing
should be centralized
src/pages/Landing/components/Body/ChatBox/Input/Input.module.scss
Outdated
Show resolved
Hide resolved
src/pages/Landing/components/Body/ChatBox/Message/Message.module.scss
Outdated
Show resolved
Hide resolved
src/pages/Landing/components/StudentTicket/Report/Report.module.scss
Outdated
Show resolved
Hide resolved
src/pages/Landing/components/StudentTicket/Report/Report.module.scss
Outdated
Show resolved
Hide resolved
src/pages/Landing/components/StudentTicket/Report/Report.module.scss
Outdated
Show resolved
Hide resolved
ArchitW
added
the
Changes Requested
Some comments left by reviwer which needs to be addressed by developer
label
Apr 18, 2021
LGTM, Good to merge |
ArchitW
removed
the
Changes Requested
Some comments left by reviwer which needs to be addressed by developer
label
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.