[BUGFIX] Fixed Polymod and Mods Support in FlxPartialSound Using OpenFL Assets

[KarimAkra]

we load the aseet's bytes with Assets.loadBytes (which works asynchronously) then create a haxe.io.BytesInput instance with the bytes retrieved instead of directly reading the file with FileSystem.read to get a FileInput for it

This should be merged with the change in this pr on Funkin

[ninjamuffin99]

this looks yummy! I will mark this for myself for testing since it doesn't seem like it's too verbose of a workaround/fix! thanks!

[EliteMasterEric]

@KarimAkra I'm not sure if your testing suggests otherwise, but it seems to me like this code is loading the whole file before cutting out a portion?

As opposed to the old code, where I believe the intent was to use the filesystem to read only a portion of the file directly from disk, this saving memory by never having the full file loaded at once.

[KarimAkra]

@EliteMasterEric
I've just made a quick comparison between the build on itch.io and the one i compiled with these changes

Both seemed to be using the same amount of memory that's varying between 220-230 mb
And it adds up around 5-10 mb on both builds every time a portion plays

So i think it's safe to say this dosent have any impact on the memory usage & optimization!

[KarimAkra]

Turns out Bytes don't get cached or allocated to memory unless they're pushed to the openfl cache map or something like that
So yes, i can confirm this dosen't impact memory usage at all

[ninjamuffin99]

hmmm it doesn't save the full audio file to memory that does seem to be correct, but one thing about this is that it does at least try to load the whole audio file right? like Assets.loadBytes(path) i assume would attempt to load the full file (even if it doesn't affect memory), and wouldn't complete the little event listener until the full file has been loaded? in which case I think something closer to the original implementation is intended, so that we ONLY load exactly the bytes we want out of the audio file, so that it hopefully loads up quicker.

i havent used fileinput and file reading too much to be honest! my implementation could be doing the same thing! but the intention is to get it to read ONLY the slice of bytes it needs/wants for a preview

[KarimAkra]

That is actually true now that you mentioned it
But to see the difference and determine the impact on load speed, i made a quick benchmark to compare the load time of FileInput and BytesInput (with loading the whole file bytes)

here are the results

Given these results, the impact on speed when using BytesInput instead of FileInput is minimal. Therefore, it should be safe to use BytesInput without significant performance concerns.

[KarimAkra]

if you're wondering what's the audio file i used in here

it's the 2hot instrument (1.50 mb)

[moondroidcoder]

After testing it on my own laptop, the impact isnt really that big, even spamming to load an hour long podcast audio file doesnt impact performance. Results, laptop specs, and the audio file are all below.
Mod testing seems to go well though.

Audio file

[EliteMasterEric]

@KarimAkra Can you revert your most recent change? Assets.loadBytes is SUPPOSED to work here, I need to fix things on the Polymod side.

[KarimAkra]

@KarimAkra Can you revert your most recent change? Assets.loadBytes is SUPPOSED to work here, I need to fix things on the Polymod side.

I looked deep into how Assets.loadBytes works before making these changes

It uses lime.utils.Bytes.fromFile (https://github.com/openfl/lime/blob/develop/src%2Flime%2F_internal%2Fbackend%2Fnative%2FNativeHTTPRequest.hx#L421-L427)

Bytes.fromFile dosen't use the lime/openfl library assets tree it's like sys.io.File.getBytes so it can't really work with polymod afaik

https://github.com/openfl/lime/blob/develop/src%2Flime%2Futils%2FBytes.hx#L94-L98

[EliteMasterEric]

Bytes.fromFile dosen't use the lime/openfl library assets tree it's like sys.io.File.getBytes so it can't really work with polymod afaik

Before it reaches that call, Lime calls AssetLibrary.loadBytes(), which gets overridden by Polymod. It just isn't implemented properly.

https://github.com/larsiusprime/polymod/blob/6d1bdf79b463ca0baa8471dfc6873ab7701c46ee/polymod/backends/LimeBackend.hx#L626-L642

[KarimAkra]

Bytes.fromFile dosen't use the lime/openfl library assets tree it's like sys.io.File.getBytes so it can't really work with polymod afaik

Before it reaches that call, Lime calls AssetLibrary.loadBytes(), which gets overridden by Polymod. It just isn't implemented properly.

https://github.com/larsiusprime/polymod/blob/6d1bdf79b463ca0baa8471dfc6873ab7701c46ee/polymod/backends/LimeBackend.hx#L626-L642

Reverted it

I think Polymod needs to use a complete alternative method for loadBytes instead of calling the one from the lime AssetLibrary

I don't really know much abt how Polymod functions so I guess you'll have figure this out

[EliteMasterEric]

I got it working on the latest develop commit of Polymod. It currently has a SLIGHT delay on the first play but otherwise seems to work well even on ZIP mods.