[BUGFIX] Fixed Polymod and Mods Support in FlxPartialSound

[KarimAkra]

This should be merged with the changes in this pr on FlxPartialSound

[ninjamuffin99]

I've tested this and seems to function with base game songs normally and good! I'll give shout to @EliteMasterEric who has more brain on polymod stuff! I have a branch in our funkin-secret repo eric if u wanna take a peak at it !

[AbnormalPoof]

Tested with a mod and it seems to work !

a.mp4

[EliteMasterEric]

This wasn't working for me, and I struggled to debug it until I realized I was on a ZIP mod and apparently Polymod wasn't implementing the override for loadBytes correctly.

[tposejank]

Silly Eric

…

On Mon, Jun 17, 2024, 12:24 a.m. Eric ***@***.***> wrote: This wasn't working for me, and I struggled to debug it until I realized I was on a ZIP mod and apparently Polymod wasn't implementing the override for loadBytes correctly. — Reply to this email directly, view it on GitHub <#2724 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATNYONPCLBJT2C6GDRSXLHLZHZQIZAVCNFSM6AAAAABJAYD7M6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZSGE4TCMBTGU> . You are receiving this because you commented.Message ID: ***@***.***>

[KarimAkra]

This wasn't working for me, and I struggled to debug it until I realized I was on a ZIP mod and apparently Polymod wasn't implementing the override for loadBytes correctly.

figured out the issue

Assets.loadBytes dosen't use the assets library tree but FileSystem for some reason..?

i'll get it fixed soon using Assets.getBytes and ThreadPool

[KarimAkra]

This wasn't working for me, and I struggled to debug it until I realized I was on a ZIP mod and apparently Polymod wasn't implementing the override for loadBytes correctly.

I've just pushed a new commit to the pr on the FlxPartialSound repo that fixes this

Here's a little video of it working on base, folder mods and zip mods songs

2024-06-17.15-21-02.mp4