Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat+fix:cx_Freeze, Actions, etc. #8

Closed
wants to merge 47 commits into from
Closed

feat+fix:cx_Freeze, Actions, etc. #8

wants to merge 47 commits into from

Conversation

@im-coder-lg im-coder-lg changed the title Actions fix fix:actions! Dec 4, 2021
This is based on the Pyinstaller build action mentioned in sumeshir26#5, this doesn't have push/pull triggers, it has a workflow dispatch.
Try fixing YAML error
@not-nef
Copy link
Member

not-nef commented Dec 4, 2021

gg, still need a tester?

@im-coder-lg
Copy link
Member Author

Yup! To check if the GUI loads+installer test for Macs, etc.

@im-coder-lg
Copy link
Member Author

Release workflow works, it drafts a release, you can edit via the web client on mobile/desktop.
We fixed everything related to Windows builds. Now, I will test macOS and Linux builds.

@im-coder-lg
Copy link
Member Author

The build error resides in UBUNTU!!!
That's the error with our actions, Mac and Linux are Unix-like, POSIX-compliant systems. PyInstaller doesn't work well with them, I think I might find a solution.

@im-coder-lg
Copy link
Member Author

Something that might seem unrelated:

AppImage” file you download them as. Users of macOS will be very familiar with the concept of AppImages as macOS applications are packaged in a very similar way. ... To run an AppImage, simply right-click it, select Properties, go to the Permissions tab and make sure Allow executing file as program is ticked.

We can release one file for two OSes. What do you say?

@sumeshir26
Copy link
Member

@im-coder-lg Yeah, AppImage for both might work, but is it required to edit the permissions?

@im-coder-lg
Copy link
Member Author

Yeah, I guess it sends a chmod command since we know that GUIs run on top of CLIs, so toggling+saving that might mean that chmod ran. But the hardest question is this: How the heck can we transform the main file into an AppImage? Seems too complex, if you ask me.

@im-coder-lg
Copy link
Member Author

And everyone says that PyInstaller creates Mac/Linux binaries. I found one on my Raspberry Pi but couldn't execute it. Maybe it's a bug in the OS. I am hoping to switch to Zorin soon, I want to do it myself but I can't find a competent USB.

@sumeshir26
Copy link
Member

For now,the current implimentation is fine, appimages can be added after v1.0

@im-coder-lg
Copy link
Member Author

im-coder-lg commented Dec 5, 2021 via email

@im-coder-lg
Copy link
Member Author

@im-coder-lg
Copy link
Member Author

im-coder-lg commented Dec 6, 2021

I have added a set of commits in im-coder-lg#2, mainly a6d5b04, aa0db69, and 26b7003. But still, it fails.

@im-coder-lg
Copy link
Member Author

Maybe we shouldn't use PyInstaller for Mac and Linux... What should we do?

@im-coder-lg
Copy link
Member Author

Sorry, I pushed the change :( but I think it's fixed

@sumeshir26
Copy link
Member

@im-coder-lg Run it!

@im-coder-lg
Copy link
Member Author

Test initiating

@sumeshir26
Copy link
Member

@im-coder-lg It seems to be running the build on the master branch. Can you run on actions-fix?

@im-coder-lg
Copy link
Member Author

im-coder-lg commented Dec 10, 2021 via email

@im-coder-lg
Copy link
Member Author

You did a mistake, maybe you added the Windows MSI on the Mac build.
I think it doesn't work like that, fixing that.

@im-coder-lg
Copy link
Member Author

I'll fix this later, too confused with this. Maybe I got an idea coming up... What do you think of this:
Windows and macOS create separate release drafts.
You can download the draft release's binary installers, the MSIs and DMGs and re-upload it into your version of the release since there's actually no way we can combine releases like linking two OSes together.

@sumeshir26
Copy link
Member

@im-coder-lg That might work...

@im-coder-lg
Copy link
Member Author

Yup, that might work...

@im-coder-lg
Copy link
Member Author

I will work on this after some time.

@sumeshir26
Copy link
Member

@im-coder-lg You know what, to improve my actions skills, I will try to work on this myself.

@im-coder-lg
Copy link
Member Author

Remember to add the workflow dispatch code too!

@sumeshir26
Copy link
Member

@im-coder-lg Run the mac workfow

@im-coder-lg
Copy link
Member Author

2 minutes, starting Chrome up, Vivaldi again slowed down(resource hogged)

@im-coder-lg
Copy link
Member Author

There is no workflow_dispatch section! Did we create a glitch?

@delete-merged-branch delete-merged-branch bot deleted the actions-fix branch December 10, 2021 08:39
@sumeshir26
Copy link
Member

@im-coder-lg Moving to #9

@sumeshir26 sumeshir26 closed this Dec 10, 2021
@im-coder-lg
Copy link
Member Author

im-coder-lg commented Dec 10, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug 🐛 ]: Github Actions
3 participants