Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Actions #9

Merged
merged 14 commits into from
Dec 11, 2021
Merged

fix: Actions #9

merged 14 commits into from
Dec 11, 2021

Conversation

sumeshir26
Copy link
Member

No description provided.

sumeshir26 and others added 12 commits November 13, 2021 08:48
* Update main.yml

Test updated checks file

* Update main.yml

* Add Workflow Dispatch to run on command.

* Create release-build.yml

This is based on the Pyinstaller build action mentioned in sumeshir26#5, this doesn't have push/pull triggers, it has a workflow dispatch.

* Update release-build.yml

Try fixing YAML error

* Update release-build.yml

* Update release-build.yml

* Rename release-build.yml to release.yml

* Delete release.yml

* Create release.yml

* Update release.yml

* Create setup.py

* Modify Setup Data

* Fix `"`s

* feat: Actions for Mac and Ubuntu (#2)

* Update release.yml

* Update main.yml

* Update main.yml

* Update main.yml

* Deactivate blur.

We could make it an optional feature, that'd be good, people can just remove the double-apostrophes(""") to uncomment the blur.

* Update requirements.txt

* Create optional-requirements.txt

People can enable blur if they want. We shall add a disclaimer on the README saying the app is in beta and the Mica Acrylic blur is buggy.

* Create packager-requirements.txt

* feat: Add setup for macos!

* Rename setup.py

* fix: Fix pyinstaller in requirements.txt

* Remove blur(again)

* Delete macos-setup.py

Co-authored-by: sumeshir26 <sumeshir26@protonmail.com>

* Remove macOS and Linux tests _temporarily_

* Rename `name` to `version` in `workspace_dispatch`

* Add cx_Freeze to packager requirements

* Update setup.py

* Update setup.py

* fix: WORKING MSI!!!

* testmode: Test `bdist_rpm`

* Remove RPM for now.

* fix: Fix UID

* Update setup.py

* Update release.yml

* Update release.yml

* Rename Asset path

* Update release.yml

* Update release.yml

* Rename release.yml to release-windows.yml

* Create release-mac.yml

* Update release-mac.yml

* Update release-mac.yml

* Update release-windows.yml

* Rename job name

* try fixing workflow dispatch error

* Delete release-windows.yml

* Delete release-mac.yml

Co-authored-by: LG <76845820+im-coder-lg@users.noreply.github.com>
Co-authored-by: LG <imcoderlg@protonmail.com>
@sumeshir26
Copy link
Member Author

@im-coder-lg Could you look over the actions tab in your fork? I ran the new actions, and they fail

@im-coder-lg
Copy link
Member

It's fairly simple. You didn't supply the tag name, I will fix this.

@im-coder-lg
Copy link
Member

But... You supplied it...

@im-coder-lg
Copy link
Member

Hold up, kinda fixed Windows, rerunning in 1 minute.

@sumeshir26
Copy link
Member Author

@im-coder-lg the owner of cx_freeze might help us withthat. Would you mind putting the screenshot of the issue and our setup.py over on the cx_freeze issue?

@sumeshir26
Copy link
Member Author

Also, since kit is your fork, i dont get access to the draft releases so can you make a test release for me to check?

@sumeshir26
Copy link
Member Author

@im-coder-lg Great! Can you give me the checklist to do?

@im-coder-lg
Copy link
Member

Creating the discussion!

@Futura-Py Futura-Py deleted a comment from im-coder-lg Dec 10, 2021
@Futura-Py Futura-Py deleted a comment from im-coder-lg Dec 10, 2021
@im-coder-lg
Copy link
Member

#10
Linked here, I'll document changes, need to change that too!

@im-coder-lg
Copy link
Member

@sumeshir26 did you delete any comments of mine recently?

@sumeshir26
Copy link
Member Author

@im-coder-lg I was just cleaning up the comments.
Is this ready for merge?

@im-coder-lg
Copy link
Member

Yeah, ready for merge.

@sumeshir26 sumeshir26 self-assigned this Dec 11, 2021
@sumeshir26 sumeshir26 merged commit 7c8c04d into Futura-Py:master Dec 11, 2021
@sumeshir26
Copy link
Member Author

sumeshir26 commented Dec 11, 2021

@im-coder-lg Thank you so much👍🏽!

@sumeshir26 sumeshir26 linked an issue Dec 11, 2021 that may be closed by this pull request
@im-coder-lg
Copy link
Member

im-coder-lg commented Dec 11, 2021

No need to mention it. This happens so rarely(to me), your project was intriguing, so I just helped out on this! This is a great project.
Can you just test the actions with the workflow dispatch trigger?

@sumeshir26
Copy link
Member Author

@im-coder-lg Wait, will test later today

@im-coder-lg
Copy link
Member

im-coder-lg commented Dec 11, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug 🐛 ]: Github Actions
2 participants