Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples in README #379

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Fix examples in README #379

merged 2 commits into from
Sep 12, 2024

Conversation

taabishm2
Copy link
Contributor

In the README examples

  • Fix loop for adding documents to the Docs object
  • In the async example, wrap await in a function which otherwise throws a syntax error

In the README examples
* Fix loop for adding documents to the `Docs` object
* In the async example, wrap await in a function which otherwise throws a syntax error
Copy link
Collaborator

@jamesbraza jamesbraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks

@jamesbraza jamesbraza added the documentation Improvements or additions to documentation label Sep 12, 2024
@jamesbraza jamesbraza enabled auto-merge (squash) September 12, 2024 06:09
@jamesbraza jamesbraza merged commit 30cb026 into Future-House:main Sep 12, 2024
2 of 3 checks passed
@jamesbraza
Copy link
Collaborator

#384 removed the google auth that was messing up CI here. Sorry about that @taabishm2 and thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants