Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No google auth, better CI names #384

Merged
merged 2 commits into from
Sep 12, 2024
Merged

No google auth, better CI names #384

merged 2 commits into from
Sep 12, 2024

Conversation

jamesbraza
Copy link
Collaborator

  • Removed google-github-actions/auth since this GitHub Action run made it clear it doesn't play nice with external members
    • I don't know why we have it here anyways
  • Updated CI names to be more readable
  • Allowing lint/test CI to be manually kicked off using gh workflow run from CLI

@jamesbraza jamesbraza added the bug Something isn't working label Sep 12, 2024
@jamesbraza jamesbraza self-assigned this Sep 12, 2024
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 12, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 12, 2024
@jamesbraza jamesbraza merged commit b045db3 into main Sep 12, 2024
3 checks passed
@jamesbraza jamesbraza deleted the removing-google-auth branch September 12, 2024 18:57
@jamesbraza jamesbraza mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mskarlin mskarlin mskarlin approved these changes

@whitead whitead Awaiting requested review from whitead

Assignees

@jamesbraza jamesbraza

Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbraza @mskarlin