-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Static page for manager dashboard #11342
Conversation
892e7d6
to
4a85ff8
Compare
2af624e
to
e57abdf
Compare
Oops, missed two strings for translation. I'll ask for them after the peer review just in case I missed any more or any change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review Peter. This is looking amazing, it's awesome seeing all the pieces coming together. Just a couple things to fix up.
apps/web/src/pages/ManagerDashboardPage/ManagerDashboardPage.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work!
loader: async () => { | ||
throw new Response("Not Found", { status: 404 }); // unfinished page | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the lines to comment out to allow the page to be routable.
🤖 Resolves #10785
👋 Introduction
This branch adds a static version of the new Manager dashboard page. It has limited functionality yet and so is not routable without a code change.
🕵️ Details
Some unfinished pieces to finish this page:
🧪 Testing
/en/manager/dashboard
📸 Screenshot