Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Static page for manager dashboard #11342

Merged
merged 19 commits into from
Sep 12, 2024

Conversation

petertgiles
Copy link
Contributor

@petertgiles petertgiles commented Aug 22, 2024

🤖 Resolves #10785

👋 Introduction

This branch adds a static version of the new Manager dashboard page. It has limited functionality yet and so is not routable without a code change.

🕵️ Details

Some unfinished pieces to finish this page:

🧪 Testing

  1. Uncomment the loader in the new route in apps/web/src/components/Router.tsx and rebuild
  2. Log in as "manager@test.com"
  3. Navigate to /en/manager/dashboard
  • matches design
  • mobile/desktop view
  • light/dark view
  • a11y

📸 Screenshot

image

@petertgiles
Copy link
Contributor Author

Oops, missed two strings for translation. I'll ask for them after the peer review just in case I missed any more or any change.

@petertgiles petertgiles marked this pull request as ready for review August 22, 2024 18:35
Copy link
Contributor

@yonikid15 yonikid15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review Peter. This is looking amazing, it's awesome seeing all the pieces coming together. Just a couple things to fix up.

apps/web/src/pages/ManagerDashboardPage/messages.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@yonikid15 yonikid15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!

Comment on lines +37 to +39
loader: async () => {
throw new Response("Not Found", { status: 404 }); // unfinished page
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the lines to comment out to allow the page to be routable.

@petertgiles petertgiles added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit f117df9 Sep 12, 2024
13 checks passed
@petertgiles petertgiles deleted the 10785-manager-dashboard-view branch September 12, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Epic] Manager Dashboard View
2 participants