Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Adds SEO to Directive page #11867

Merged
merged 1 commit into from
Oct 28, 2024
Merged

[Fix] Adds SEO to Directive page #11867

merged 1 commit into from
Oct 28, 2024

Conversation

mnigh
Copy link
Contributor

@mnigh mnigh commented Oct 28, 2024

🤖 Resolves #11862.

👋 Introduction

This PR adds the missing SEO component with title and subtitle to the Directive page.

🧪 Testing

  1. pnpm build
  2. Navigate to http://localhost:3000/en/directive-on-digital-talent
  3. Verify Directive page title and subtitle of page is used for <head> title and description

📸 Screenshots

Screen Shot 2024-10-28 at 11 32 42 Screen Shot 2024-10-28 at 11 33 12

petertgiles
petertgiles approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@petertgiles petertgiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@mnigh mnigh added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit f406ee2 Oct 28, 2024
12 checks passed
@mnigh mnigh deleted the 11862-directive-page-seo branch October 28, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertgiles petertgiles petertgiles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Directive page missing SEO component
2 participants
@mnigh @petertgiles