Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Adds SEO to Directive page #11867

Merged
merged 1 commit into from
Oct 28, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions apps/web/src/pages/DirectivePage/DirectivePage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import {
import Hero from "~/components/HeroDeprecated";
import useBreadcrumbs from "~/hooks/useBreadcrumbs";
import useRoutes from "~/hooks/useRoutes";
import SEO from "~/components/SEO/SEO";

import Resources from "./Resources";

Expand Down Expand Up @@ -76,6 +77,13 @@ export const pageTitle = defineMessage({
description: "Title for the digital talent directive page",
});

export const pageSubtitle = defineMessage({
defaultMessage:
"Learn more about how the Government of Canada is strengthening the talent base of the GC digital community.",
id: "c/u1K+",
description: "Subtitle for the digital talent directive page",
});

export const Component = () => {
const intl = useIntl();
const locale = getLocale(intl);
Expand Down Expand Up @@ -103,14 +111,13 @@ export const Component = () => {

return (
<>
<SEO
title={intl.formatMessage(pageTitle)}
description={intl.formatMessage(pageSubtitle)}
/>
<Hero
title={intl.formatMessage(pageTitle)}
subtitle={intl.formatMessage({
defaultMessage:
"Learn more about how the Government of Canada is strengthening the talent base of the GC digital community.",
id: "c/u1K+",
description: "Subtitle for the digital talent directive page",
})}
subtitle={intl.formatMessage(pageSubtitle)}
crumbs={crumbs}
linkSlot={
<>
Expand Down
Loading