Skip to content
This repository has been archived by the owner on Mar 16, 2021. It is now read-only.

Upgrade gradlew to 4.1 #112

Merged
merged 6 commits into from
Sep 22, 2017
Merged

Upgrade gradlew to 4.1 #112

merged 6 commits into from
Sep 22, 2017

Conversation

passsy
Copy link
Contributor

@passsy passsy commented Sep 21, 2017

improves compatibily with Android Studio 3.0

Required upgrade of bintray plugin novoda/bintray-release#115

improves compatibily with Android Studio 3.0

Required upgrade of bintray plugin novoda/bintray-release#115
@StefMa
Copy link
Contributor

StefMa commented Sep 21, 2017

Gradle 4.2 just released.. Any reasons why using 4.1?

I would recommend to upgrade the bintray release in this PR as well...

@passsy
Copy link
Contributor Author

passsy commented Sep 21, 2017

Oh, thought it is still rc2. Time flies. I also upgraded the bintray plugin (and tested it)

@passsy
Copy link
Contributor Author

passsy commented Sep 21, 2017

I tried upgrading to 4.2 but it doesn't work. provided dependencies cannot be added to the dependencies due to internal gradle changes which aren't supported by the bintray release plugin as of now. We should add that

Stacktrace Caused by: groovy.lang.MissingPropertyException: No such property: FOR_RUNTIME for class: org.gradle.api.attributes.Usage at com.novoda.gradle.release.AndroidLibrary$RuntimeUsage.getUsage(AndroidLibrary.groovy:53) at org.gradle.api.publish.maven.internal.publication.DefaultMavenPublication.from(DefaultMavenPublication.java:132) at org.gradle.internal.metaobject.BeanDynamicObject$MetaClassAdapter.invokeMethod(BeanDynamicObject.java:479) at org.gradle.internal.metaobject.BeanDynamicObject.tryInvokeMethod(BeanDynamicObject.java:191) at org.gradle.internal.metaobject.CompositeDynamicObject.tryInvokeMethod(CompositeDynamicObject.java:98) at org.gradle.internal.metaobject.MixInClosurePropertiesAsMethodsDynamicObject.tryInvokeMethod(MixInClosurePropertiesAsMethodsDynamicObject.java:30) at org.gradle.internal.metaobject.ConfigureDelegate.invokeMethod(ConfigureDelegate.java:59) at com.novoda.gradle.release.ReleasePlugin$_addArtifact_closure3.doCall(ReleasePlugin.groovy:65) at org.gradle.api.internal.ClosureBackedAction.execute(ClosureBackedAction.java:71) at org.gradle.util.ConfigureUtil.configureTarget(ConfigureUtil.java:160) at org.gradle.util.ConfigureUtil.configure(ConfigureUtil.java:106) at org.gradle.util.ConfigureUtil$1.execute(ConfigureUtil.java:123) at org.gradle.api.internal.AbstractPolymorphicDomainObjectContainer.create(AbstractPolymorphicDomainObjectContainer.java:61) at org.gradle.api.publish.internal.DefaultPublicationContainer_Decorated.create(Unknown Source) at org.gradle.api.publish.internal.DefaultPublicationContainer_Decorated$create.call(Unknown Source) at com.novoda.gradle.release.ReleasePlugin.addArtifact(ReleasePlugin.groovy:57) at com.novoda.gradle.release.ReleasePlugin$_attachArtifacts_closure2.doCall(ReleasePlugin.groovy:47) at com.novoda.gradle.release.ReleasePlugin.attachArtifacts(ReleasePlugin.groovy:45) at com.novoda.gradle.release.ReleasePlugin$_apply_closure1.doCall(ReleasePlugin.groovy:15) at org.gradle.listener.ClosureBackedMethodInvocationDispatch.dispatch(ClosureBackedMethodInvocationDispatch.java:40) at org.gradle.listener.ClosureBackedMethodInvocationDispatch.dispatch(ClosureBackedMethodInvocationDispatch.java:25) at org.gradle.internal.event.AbstractBroadcastDispatch.dispatch(AbstractBroadcastDispatch.java:42) at org.gradle.internal.event.BroadcastDispatch$SingletonDispatch.dispatch(BroadcastDispatch.java:230) at org.gradle.internal.event.BroadcastDispatch$SingletonDispatch.dispatch(BroadcastDispatch.java:149) at org.gradle.internal.event.AbstractBroadcastDispatch.dispatch(AbstractBroadcastDispatch.java:58) at org.gradle.internal.event.BroadcastDispatch$CompositeDispatch.dispatch(BroadcastDispatch.java:324) at org.gradle.internal.event.BroadcastDispatch$CompositeDispatch.dispatch(BroadcastDispatch.java:234) at org.gradle.internal.event.ListenerBroadcast.dispatch(ListenerBroadcast.java:140) at org.gradle.internal.event.ListenerBroadcast.dispatch(ListenerBroadcast.java:37) at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93) at com.sun.proxy.$Proxy26.afterEvaluate(Unknown Source) at org.gradle.configuration.project.LifecycleProjectEvaluator.notifyAfterEvaluate(LifecycleProjectEvaluator.java:76) ... 152 more

@StefMa
Copy link
Contributor

StefMa commented Sep 22, 2017

Travis is so easy 😀
Thanks 👍

@StefMa StefMa merged commit 6bc2ef3 into master Sep 22, 2017
@StefMa StefMa deleted the gradle_4.1 branch September 22, 2017 08:14
@passsy passsy mentioned this pull request Oct 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

2 participants