Gradle 3.5 support #115
Gradle 3.5 support #115
Conversation
./gradlew wrapper --gradle-version 3.5 --distribution-type all
|
Can one of the admins review this PR? |
|
|
||
| class AndroidLibrary implements SoftwareComponentInternal { | ||
|
|
||
| private final Usage runtimeUsage | ||
| private final UsageContext runtimeUsage |
There was a problem hiding this comment.
Are these changes going to work if the users of the plugin have gradle version older than 3.5? I guess with this, the library will require the users to use version 3.4?
There was a problem hiding this comment.
yes, it doesn't work with 3.3 and before. It works 3.4+
There was a problem hiding this comment.
I guess it is fine as long as we make it clear on the release notes.
There was a problem hiding this comment.
@tasomaniac I just update issue #112. I don't think we have other option than re-release for 3.4+ only. More details can be found here.
|
Why is the CI still using my token. 😡 |
|
@stefanhoth it seems like a glitch. Apparently PRB has not been triggered at all. |
|
Retest this please. |
|
Ok to test. |
|
Ok that was it. Sorry for the spam and thank you for the contribution @passsy! |
|
@mr-archano do you think it's worth throwing in the code if the version of gradle isn't 3.4+ or will a warning in the readme be enough? |
|
@ouchadam it will fail anyways with mysterious error output. If we can detect the version of the gradle used, we can fail fast and tell them to update their gradle. Probably this will happen when they update our plugin. So it will be easier for them to update gradle too. |
|
I'm absolutely for the gradle version detection with a good error message |
improves compatibily with Android Studio 3.0 Required upgrade of bintray plugin novoda/bintray-release#115
Fixes #112, #113
Upgraded gradle to 3.4.1 but since 3.5 was just released I upgraded to the latest version.
Upgraded
AndroidLibrary.javato support the latest internal API changes.I tried to solve it without using any internal APIs but AFAIK this would involve manual pom adjustments. This is all solved by the internal API.