Skip to content
This repository has been archived by the owner on Mar 16, 2021. It is now read-only.

Bugfix: Lint Checks not Triggering #187

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jreehuis
Copy link

Description

This PR will solve a couple of issues with the implemented Lint Checks for TI.

  1. TI Lint Checks are not executed prior Build Tools 3.3 Caused by the lately increased the Build Tools version and so the Lint API Version while using com.android.tools.lint.detector.api.CURRENT_API as Lint Version. So the checks when marked as not compatible with the Build Tools used.
  2. Check if provideView() is overridden always returns true Caused by the fact that this check was checking the whole inheritance tree and so found the implementation in the TI base classes.
  3. Check if the View Interface is implemented did not check more than the direct super class

How to Test

Play with the following scenarios:

  • Remove the implements HelloWorldView in the HelloWorldActivity of the sample app
  • Remove the implements HelloWorldView but override provideView() in the HelloWorldActivity of the sample app
  • Use TI v0.10.0-SNAPSHOT of this branch in another project and have an TiActivity which does not implement the given TiView subclass

Note

Testing Lint Checks in the Sample Project did not work reliably for me. This seems to be an Android Studio Issue as quite often an Invalidate Caches and Restart help.
A commandline lint run were reporting the errors reliably.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

1 participant