This repository has been archived by the owner on Mar 16, 2021. It is now read-only.
Refactoring: Lint Name and Stub Extraction #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ust used through base implementations
…eter count and return type
…ations in non TiView interfaces
… TiView child interface
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How to Test
As only some "strings" got extracted it should be sufficient to rely on the tests.
If you want to test this anyways: Follow the test instructions of #187 and #188
Merge Information
This PR builds on top of #188 and transitive on #187 so please do not merge this after #188 and #187 .
It will also ease the PR review a lot.
Note
Testing Lint Checks in the Sample Project did not work reliably for me. This seems to be an Android Studio Issue as quite often an
Invalidate Caches and Restarthelp.A commandline lint run were reporting the errors reliably.