Create jbrowse error screen when resource fails to load #915
Conversation
|
Let me know when / if you need this tested. |
|
I think it is probably done for the case I was interested in, namely the plugin failing to load. There are actually other cases such as the storeClass and trackType not loading correctly, and adding error handlers for those would be useful too (they do not give any good indication of failing on the screen, only and error via the javascript console) |
|
👍 |
ghost
assigned 
src/JBrowse/Browser.js
Outdated
| console.error(error); | ||
| deferred.reject('A resource failed to load '+error.src + ':' + error.info[0]); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Could you de-install this error handler after the plugin loading is finished? It's specific to the plugin loading, and require is a persistent global thing.
If something else fails to load later, it will try again to reject the plugin-loading deferred.
There was a problem hiding this comment.
Found from this thread that it can return a handle that can be used to later remove it dojo/loader#14
This allows the glyph error handler to be separate at the later stage (added that too)
There was a problem hiding this comment.
This is reverted now, I think just having a global require.on error handler in index.html that creates an error screen sort of a better approach. Potentially this is a downside because if one track fails to load it just jumps to the error screen rather than just continuing to display other tracks, but the idea of adding and removing the error handler didnt seem to be working.
Also the "not-a-module" error can be caught now
cmdcolin
force-pushed
the
add_error_when_plugin_fails
branch
from
1b192e8
to
56af3e3
Compare
When a plugin that is specified by jbrowse config fails to load due to not being located e.g. 404, the result seems to be a blank white screen which is hard to debug. This adds an error handler that tries to clarify that by giving an error screen that looks like this now