06/26/2024 Production Deploy #1120

ccostino · 2024-06-26T20:50:47Z

A note to PR reviewers: it may be helpful to review our code review documentation to know what to keep in mind while reviewing pull requests.

Description

This is our production deploy for 6/26/2024. Full release notes can be viewed here!

Security Considerations

All changes have been reviewed and tested prior to being included here.

Bumps [botocore](https://github.com/boto/botocore) from 1.34.115 to 1.34.116. - [Changelog](https://github.com/boto/botocore/blob/develop/CHANGELOG.rst) - [Commits](boto/botocore@1.34.115...1.34.116) --- updated-dependencies: - dependency-name: botocore dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bump botocore from 1.34.115 to 1.34.116

Bumps [moto](https://github.com/getmoto/moto) from 5.0.8 to 5.0.9. - [Release notes](https://github.com/getmoto/moto/releases) - [Changelog](https://github.com/getmoto/moto/blob/master/CHANGELOG.md) - [Commits](getmoto/moto@5.0.8...5.0.9) --- updated-dependencies: - dependency-name: moto dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

add some debug around report generation

Bump moto from 5.0.8 to 5.0.9

Look into enabling Dependabot Code Scanning for our API and admin repos

Bumps [boto3](https://github.com/boto/boto3) from 1.34.114 to 1.34.116. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.34.114...1.34.116) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bump boto3 from 1.34.114 to 1.34.116

replace utcnow with timezone naive utc call

Exception Investigation: app.notify_client:InviteTokenError

bring coverage back up to 95%

This changeset fixes a recently added debug statement that was assuming a list was not empty, which was causing end-to-end tests to break in the admin site. Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>

Fix debug statement

Bumps [botocore](https://github.com/boto/botocore) from 1.34.116 to 1.34.117. - [Changelog](https://github.com/boto/botocore/blob/develop/CHANGELOG.rst) - [Commits](boto/botocore@1.34.116...1.34.117) --- updated-dependencies: - dependency-name: botocore dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bump boto3 from 1.34.128 to 1.34.131

Bumps [setuptools](https://github.com/pypa/setuptools) from 70.0.0 to 70.1.0. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/main/NEWS.rst) - [Commits](pypa/setuptools@v70.0.0...v70.1.0) --- updated-dependencies: - dependency-name: setuptools dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bump setuptools from 70.0.0 to 70.1.0

Need magic PII-free debugging method for API

…red-module Shared: remove deprecated recursive_delete

Upgrade tj-actions from v41 to v44 in Staging

Staging: Redis upgrade final step

Upgrade tj-actions from v41 to v44 in Demo and Prod

Bumps [botocore](https://github.com/boto/botocore) from 1.34.131 to 1.34.133. - [Changelog](https://github.com/boto/botocore/blob/develop/CHANGELOG.rst) - [Commits](boto/botocore@1.34.131...1.34.133) --- updated-dependencies: - dependency-name: botocore dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bump botocore from 1.34.131 to 1.34.133

Bumps [setuptools](https://github.com/pypa/setuptools) from 70.1.0 to 70.1.1. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/main/NEWS.rst) - [Commits](pypa/setuptools@v70.1.0...v70.1.1) --- updated-dependencies: - dependency-name: setuptools dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bump setuptools from 70.1.0 to 70.1.1

Update name of Redis to include v70

github-actions · 2024-06-26T20:51:14Z

Terraform Format and Style: success
Terraform Initialization: success
Terraform Validation: success
Terraform Plan: success

Show Plan


module.database.data.cloudfoundry_space.space: Reading...
module.redis.data.cloudfoundry_space.space: Reading...
module.ses_email.data.cloudfoundry_service.ses: Reading...
module.redis-v70.data.cloudfoundry_space.space: Reading...
module.database.data.cloudfoundry_service.rds: Reading...
module.sns_sms.data.cloudfoundry_space.space: Reading...
module.csv_upload_bucket.data.cloudfoundry_space.space: Reading...
module.ses_email.data.cloudfoundry_space.space: Reading...
module.csv_upload_bucket.data.cloudfoundry_service.s3: Reading...
module.sns_sms.data.cloudfoundry_service.sns: Reading...
module.csv_upload_bucket.data.cloudfoundry_service.s3: Read complete after 1s [id=440ce9d9-b108-4bbe-80b4-08338f3cc25b]
module.redis.data.cloudfoundry_service.redis: Reading...
module.ses_email.data.cloudfoundry_service.ses: Read complete after 1s [id=8a75c59c-0c4b-4764-907c-b0760c7278a0]
module.redis-v70.data.cloudfoundry_service.redis: Reading...
module.sns_sms.data.cloudfoundry_service.sns: Read complete after 1s [id=ed5b0e74-dacc-4511-8514-410bef51b554]
module.egress-space.data.cloudfoundry_org.org: Reading...
module.database.data.cloudfoundry_service.rds: Read complete after 1s [id=dcfb1d43-f22c-42d3-962c-7ae04eda24e7]
module.redis.data.cloudfoundry_space.space: Read complete after 1s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.redis-v70.data.cloudfoundry_space.space: Read complete after 1s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.redis.data.cloudfoundry_service.redis: Read complete after 0s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.redis.cloudfoundry_service_instance.redis: Refreshing state... [id=c6d73ed7-69ba-4720-a459-7b80200006c8]
module.redis-v70.data.cloudfoundry_service.redis: Read complete after 0s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.sns_sms.data.cloudfoundry_space.space: Read complete after 1s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.sns_sms.cloudfoundry_service_instance.sns: Refreshing state... [id=dfa60432-eab1-456b-8a24-9a34312939ed]
module.database.data.cloudfoundry_space.space: Read complete after 1s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.database.cloudfoundry_service_instance.rds: Refreshing state... [id=9360890e-0458-41d0-99ce-071ce7f5bef9]
module.csv_upload_bucket.data.cloudfoundry_space.space: Read complete after 1s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.csv_upload_bucket.cloudfoundry_service_instance.bucket: Refreshing state... [id=59028298-4427-4516-907d-097d99dda5c5]
module.ses_email.data.cloudfoundry_space.space: Read complete after 1s [id=0b28b133-9f7b-49f1-9f34-a179cbb2549f]
module.egress-space.data.cloudfoundry_org.org: Read complete after 0s [id=9e428562-a2d9-41b4-9c23-1ef5237fb44e]
module.ses_email.cloudfoundry_service_instance.ses: Refreshing state... [id=a113b8a3-5a87-4920-85c6-00c18a8c389e]
module.egress-space.data.cloudfoundry_user.users["steven.reilly@gsa.gov"]: Reading...
module.egress-space.data.cloudfoundry_user.users["bbb35677-6906-4f8d-b230-bb4755d7886a"]: Reading...
module.egress-space.cloudfoundry_space.public_egress: Refreshing state... [id=fa2417a9-297e-40e0-a517-f4f1f4989556]
module.egress-space.data.cloudfoundry_user.users["bbb35677-6906-4f8d-b230-bb4755d7886a"]: Read complete after 0s [id=74b9cc1c-d8fa-4e70-8eba-c7d66343ad9c]
module.egress-space.data.cloudfoundry_user.users["steven.reilly@gsa.gov"]: Read complete after 0s [id=ffd00a3e-aa1a-42e1-a81a-5f60420658c2]
module.egress-space.cloudfoundry_space_users.deployers: Refreshing state... [id=63a559ae-ceb6-3066-9eb0-b57347e2bece]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # null_resource.prevent_destroy will be created
  + resource "null_resource" "prevent_destroy" {
      + id = (known after apply)
    }

  # module.redis-v70.cloudfoundry_service_instance.redis will be created
  + resource "cloudfoundry_service_instance" "redis" {
      + id                             = (known after apply)
      + json_params                    = jsonencode(
            {
              + engineVersion = "7.0"
            }
        )
      + name                           = "notify-api-redis-v70-demo"
      + replace_on_params_change       = false
      + replace_on_service_plan_change = false
      + service_plan                   = "39e035d8-f847-4bf5-a2ee-521c3118cc42"
      + space                          = "0b28b133-9f7b-49f1-9f34-a179cbb2549f"
      + tags                           = []
    }

Plan: 2 to add, 0 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

Pusher: @ccostino, Action: pull_request

github-actions · 2024-06-26T20:51:18Z

Terraform Format and Style: success
Terraform Initialization: success
Terraform Validation: success
Terraform Plan: success

Show Plan


module.database.data.cloudfoundry_service.rds: Reading...
module.egress-space.data.cloudfoundry_org.org: Reading...
module.redis.data.cloudfoundry_service.redis: Reading...
module.ses_email.data.cloudfoundry_service.ses: Reading...
module.database.data.cloudfoundry_space.space: Reading...
module.sns_sms.data.cloudfoundry_space.space: Reading...
module.redis-v70.data.cloudfoundry_service.redis: Reading...
module.csv_upload_bucket.data.cloudfoundry_service.s3: Reading...
module.ses_email.data.cloudfoundry_space.space: Reading...
module.redis-v70.data.cloudfoundry_space.space: Reading...
module.redis-v70.data.cloudfoundry_service.redis: Read complete after 0s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.egress-space.data.cloudfoundry_org.org: Read complete after 0s [id=9e428562-a2d9-41b4-9c23-1ef5237fb44e]
module.redis.data.cloudfoundry_space.space: Reading...
module.sns_sms.data.cloudfoundry_service.sns: Reading...
module.database.data.cloudfoundry_space.space: Read complete after 0s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.csv_upload_bucket.data.cloudfoundry_space.space: Reading...
module.ses_email.data.cloudfoundry_space.space: Read complete after 0s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.egress-space.cloudfoundry_space.public_egress: Refreshing state... [id=63506464-c7e2-4743-a7b3-4a8d45f14fb9]
module.redis-v70.data.cloudfoundry_space.space: Read complete after 0s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.egress-space.data.cloudfoundry_user.users["dd4002f6-951d-44b2-b88c-1b828e98dc01"]: Reading...
module.sns_sms.data.cloudfoundry_space.space: Read complete after 0s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.csv_upload_bucket.data.cloudfoundry_service.s3: Read complete after 0s [id=440ce9d9-b108-4bbe-80b4-08338f3cc25b]
module.ses_email.data.cloudfoundry_service.ses: Read complete after 0s [id=8bf5287d-587b-4696-8e53-a6ffdba211c0]
module.ses_email.cloudfoundry_service_instance.ses: Refreshing state... [id=36cf8e1d-f2b7-4b44-9ef6-998393cb547f]
module.redis.data.cloudfoundry_service.redis: Read complete after 0s [id=045871d3-d9a8-4a9b-a844-00a067fab054]
module.redis.data.cloudfoundry_space.space: Read complete after 0s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.redis.cloudfoundry_service_instance.redis: Refreshing state... [id=ccb2abc6-1986-4c55-b8cf-d21e313f26c2]
module.egress-space.data.cloudfoundry_user.users["dd4002f6-951d-44b2-b88c-1b828e98dc01"]: Read complete after 0s [id=c51e169a-d8d0-4179-adff-ef871ba9e8ae]
module.csv_upload_bucket.data.cloudfoundry_space.space: Read complete after 0s [id=4447d89a-9735-4d82-94e1-dc07713aa460]
module.csv_upload_bucket.cloudfoundry_service_instance.bucket: Refreshing state... [id=0d3aa4e5-7e26-4eef-bf6a-f12818b8a687]
module.database.data.cloudfoundry_service.rds: Read complete after 0s [id=dcfb1d43-f22c-42d3-962c-7ae04eda24e7]
module.database.cloudfoundry_service_instance.rds: Refreshing state... [id=6267206c-b5ab-4dbb-8662-02f2ada85876]
module.sns_sms.data.cloudfoundry_service.sns: Read complete after 0s [id=37cbe836-d604-45d1-b1f8-1403f7cb3ff7]
module.sns_sms.cloudfoundry_service_instance.sns: Refreshing state... [id=ccaf756d-74a2-4903-b9cf-08ad0123ecbc]
module.egress-space.cloudfoundry_space_users.deployers: Refreshing state... [id=11c85b1d-3895-b7a0-260c-a036d272226d]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # null_resource.prevent_destroy will be created
  + resource "null_resource" "prevent_destroy" {
      + id = (known after apply)
    }

  # module.redis-v70.cloudfoundry_service_instance.redis will be created
  + resource "cloudfoundry_service_instance" "redis" {
      + id                             = (known after apply)
      + json_params                    = jsonencode(
            {
              + engineVersion = "7.0"
            }
        )
      + name                           = "notify-api-redis-v70-production"
      + replace_on_params_change       = false
      + replace_on_service_plan_change = false
      + service_plan                   = "39e035d8-f847-4bf5-a2ee-521c3118cc42"
      + space                          = "4447d89a-9735-4d82-94e1-dc07713aa460"
      + tags                           = []
    }

Plan: 2 to add, 0 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

Pusher: @ccostino, Action: pull_request

jskinne3

All the changes that are mine look like what I expect

Kenneth Kehl and others added 30 commits May 14, 2024 07:23

add some debug around report generation

c3a20ec

fix invite text

a274aae

fix flake 8

e7c6853

bring coverage back up to 95%

a749b8c

add omission of migrations to checks.yml

71931a5

Create codeql.yml

6f420c3

replace utcnow with timezone naive utc call

752a13f

remove datetime.utcnow()

905df17

remove datetime.utcnow()

07650e3

merge from main

362b2ad

update

f1206a7

merge from main

7f852ac

merge from main again

4aba47e

remove v2

22ffc56

Merge pull request #1038 from GSA/dependabot/pip/botocore-1.34.116

0d3a0c5

Bump botocore from 1.34.115 to 1.34.116

Merge pull request #987 from GSA/pr_debug_reports

543a20f

add some debug around report generation

Merge pull request #1039 from GSA/dependabot/pip/moto-5.0.9

37691ff

Bump moto from 5.0.8 to 5.0.9

Merge pull request #1018 from GSA/terrazoon-patch-1

25df0e2

Look into enabling Dependabot Code Scanning for our API and admin repos

Merge pull request #1041 from GSA/dependabot/pip/boto3-1.34.116

638b068

Bump boto3 from 1.34.114 to 1.34.116

merge from main

bce5220

merge from main

f74d08a

Merge pull request #1022 from GSA/notify-api-951

a555bd4

replace utcnow with timezone naive utc call

Merge pull request #992 from GSA/notify-admin-1396

a3ef6de

Exception Investigation: app.notify_client:InviteTokenError

Merge pull request #993 from GSA/notify-api-843

67392e6

bring coverage back up to 95%

Fix debug statement

7aa6f62

This changeset fixes a recently added debug statement that was assuming a list was not empty, which was causing end-to-end tests to break in the admin site. Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>

Merge pull request #1042 from GSA/fix-debug-statement

e792f89

Fix debug statement

jskinne3 and others added 18 commits June 24, 2024 15:22

Merge branch 'main' into jskinne3-remove-deprecated-from-shared-module

1dacb1f

Merge pull request #1112 from GSA/dependabot/pip/boto3-1.34.131

88b5c3a

Bump boto3 from 1.34.128 to 1.34.131

Merge pull request #1113 from GSA/dependabot/pip/setuptools-70.1.0

4cb99d3

Bump setuptools from 70.0.0 to 70.1.0

Merge pull request #1076 from GSA/notify-api-937

ec538da

Need magic PII-free debugging method for API

Merge pull request #1098 from GSA/jskinne3-remove-deprecated-from-sha…

cac5ef7

…red-module Shared: remove deprecated recursive_delete

Upgrade major verion 41 to 44 of tj-actions

28d77b1

Merge pull request #1114 from GSA/jskinne3-upgrade-tj-actions

35f2a0e

Upgrade tj-actions from v41 to v44 in Staging

Upgrade from v41 to v44 in demo and prod deploy workflows

8aa3683

Remove old version of Redis from Staging (and Sandbox)

a07a790

Merge pull request #1116 from GSA/jskinne3-remove-v62-redis-staging

efea5c9

Staging: Redis upgrade final step

Merge pull request #1115 from GSA/jskinne3-upgrade-tj-actions-demo-prod

52d02f3

Upgrade tj-actions from v41 to v44 in Demo and Prod

Merge pull request #1117 from GSA/dependabot/pip/botocore-1.34.133

9d2ac37

Bump botocore from 1.34.131 to 1.34.133

Merge pull request #1118 from GSA/dependabot/pip/setuptools-70.1.1

ceaca41

Bump setuptools from 70.1.0 to 70.1.1

Update name of Redis to include v70

063ec69

Merge pull request #1119 from GSA/jskinne3-manifest-update-redis-name

6dd27a0

Update name of Redis to include v70

ccostino added the engineering label Jun 26, 2024

ccostino requested a review from stvnrlly June 26, 2024 20:50

ccostino self-assigned this Jun 26, 2024

ccostino temporarily deployed to demo June 26, 2024 20:50 — with GitHub Actions Inactive

ccostino temporarily deployed to production June 26, 2024 20:50 — with GitHub Actions Inactive

ccostino temporarily deployed to staging June 26, 2024 20:52 — with GitHub Actions Inactive

jskinne3 approved these changes Jun 26, 2024

View reviewed changes

stvnrlly approved these changes Jun 26, 2024

View reviewed changes

stvnrlly merged commit 9ca8e0e into production Jun 26, 2024
17 checks passed

jskinne3 temporarily deployed to staging June 27, 2024 00:45 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

06/26/2024 Production Deploy #1120

06/26/2024 Production Deploy #1120

ccostino commented Jun 26, 2024 •

edited

Loading

github-actions bot commented Jun 26, 2024

github-actions bot commented Jun 26, 2024

jskinne3 left a comment

06/26/2024 Production Deploy #1120

06/26/2024 Production Deploy #1120

Conversation

ccostino commented Jun 26, 2024 • edited Loading

Description

Security Considerations

github-actions bot commented Jun 26, 2024

github-actions bot commented Jun 26, 2024

jskinne3 left a comment

Choose a reason for hiding this comment

ccostino commented Jun 26, 2024 •

edited

Loading