Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test for issue #835 so it correctly tests type pretty printer. #1413

Closed
wants to merge 1 commit into from
Closed

Conversation

taimoorzaeem
Copy link
Contributor

Fixes issue #1329.

@RyanGlScott
Copy link
Contributor

Thanks! I think the CI is failing due to an issue that was recently fixed on master. Can you rebase this PR on top of master?

@taimoorzaeem
Copy link
Contributor Author

Yeah sure! Done.

@@ -1,9 +1,4 @@
Loading module Cryptol
Loading module Cryptol
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is failing on this test with:

      issue835.icry: [Failed]
1a2
> Loading module Cryptol

# If output is OK:
cp /home/runner/work/cryptol/cryptol/output/./tests/issues/issue835.icry.stdout \
     /home/runner/work/cryptol/cryptol/tests/issues/issue835.icry.stdout

This patch deletes one of the Loading module Cryptol lines, but I think both are required. Indeed, if I run issue835.icry locally, I get:

Loading module Cryptol
Loading module Cryptol
Loading module Float
number`{1, Float _ _} :
  {n, m} (ValidFloat n m, Literal 1 (Float n m)) => Float n m

One of those Loading module Cryptols comes from starting up Cryptol, and another comes from :m Float.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. I am going to close this pull request and make a new pull request including these changes.

@taimoorzaeem taimoorzaeem deleted the issue1329 branch August 26, 2022 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants