Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test for issue #835 so it correctly tests type pretty printer. #1413

Closed
wants to merge 1 commit into from
Closed

Add regression test for issue #835 so it correctly tests type pretty printer. #1413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/issues/issue835.icry
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
:m Float
:t (zero : Float 5 11) <$ zero
:t number`{1, Float _ _}
9 changes: 2 additions & 7 deletions tests/issues/issue835.icry.stdout
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
Loading module Cryptol
Loading module Cryptol
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is failing on this test with:

      issue835.icry: [Failed]
1a2
> Loading module Cryptol

# If output is OK:
cp /home/runner/work/cryptol/cryptol/output/./tests/issues/issue835.icry.stdout \
     /home/runner/work/cryptol/cryptol/tests/issues/issue835.icry.stdout

This patch deletes one of the Loading module Cryptol lines, but I think both are required. Indeed, if I run issue835.icry locally, I get:

Loading module Cryptol
Loading module Cryptol
Loading module Float
number`{1, Float _ _} :
  {n, m} (ValidFloat n m, Literal 1 (Float n m)) => Float n m

One of those Loading module Cryptols comes from starting up Cryptol, and another comes from :m Float.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. I am going to close this pull request and make a new pull request including these changes.

Loading module Float

[error] at issue835.icry:2:4--2:31:
• Type `Float 5 11` does not support signed comparisons.
arising from
use of expression (<$)
at issue835.icry:2:4--2:31
number`{1, Float _ _} :
{n, m} (ValidFloat n m, Literal 1 (Float n m)) => Float n m