Add pytest to deps and CI #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinorr
commented
Apr 29, 2024
pyproject.toml
Outdated
| @@ -14,7 +14,7 @@ description = "Hydrological Simulation Program - Python" | |||
| dependencies = [ | |||
| "cltoolbox", | |||
| "numba", | |||
| "pandas", | |||
| "pandas>=1.5,<2", | |||
There was a problem hiding this comment.
we should refactor all calls to df.append() since it's deprecated. use pandas.concat([df1, df2]) going forward
austinorr
commented
Apr 29, 2024
| @@ -46,6 +46,11 @@ keywords = [ | |||
| license = {file = "LICENSE"} | |||
| requires-python = ">=3.10" | |||
|
|
|||
| [project.optional-dependencies] | |||
| slim = ["numba", "pandas"] | |||
There was a problem hiding this comment.
most of this library doesn't depend on the cli, so there can be a slim option. In fact, a better approach would be to move the dependency on cltoolbox to an optional dependency tag called cli = ["cltoolbox"].
Fixes * Allow the HDF filename to be passed to main function instead of only io_manager instance. Having main only accept io_manager broke all ipython notebooks. * Removed "print(table)" from readUCI which I think was a debugging statement. IPython Notebook Fixes * Edited some of the ipython notebooks that tried to find an element time-series with an old name, for example tried to find "SURO" instead of the new name "SURO_sum". * Edited some of the ipython notebooks so that filenames were case sensitive. Deprecations * The append function is no longer available for DataFrames and changed to pd.concat form. * In pandas 3.0, to_hdf will require the "key" to be a keyword argument instead of a positional argument and made that change now to silence the deprecation message. Format * Removed trailing spaces from some files. * Fixed not a multiple of 4 spaces indentation in at least one file. * Renamed files with spaces in their names, replacing spaces with "_". Documentation * Additional edits to the README.rst. * Reshaped some docstrings into Numpy format.
…e other action to test 3.11
Cleanup actions
…s with undefined variables, as noted in PR respec#159.
…ease, for GENER operations and outputting mean values
misc fixes... Merging this one in, will have a few touch-ups afterward to resolve this append/concat issue.
pyproject.toml -- attempt to add version dependency for pandas
…inning to allow test; TODO: refactor readUCI for pandas>=2
…aths at the end of gitignore
…nyones long-running hspf job
…ch room for improvement
austinorr
force-pushed
the
pytest
branch
2 times, most recently
from
ce4e237
to
10fcb7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
pytestto the optional project dependencies, and should get automated tests passing in CI (partially, there's another PR coming that fixes the packaging/install so that the cli works again).