Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update example apps to react native 0.67 [CRNS-538] #1199

Merged
merged 20 commits into from
Mar 12, 2022
Merged

feat: update example apps to react native 0.67 [CRNS-538] #1199

merged 20 commits into from
Mar 12, 2022

Conversation

santhoshvai
Copy link
Member

@santhoshvai santhoshvai commented Mar 9, 2022 •
edited
Loading

🎯 Goal

  • Update example apps to the latest stable react-native version.
  • Add clean scripts to yarn to make future upgrades easier
  • Remove the unused NativeMessaging example app
  • Unify usage of cocoapods and ruby versions as introduced in 0.67 template: Introduce Gemfile, ruby-version facebook/react-native#32303 and also adapt the sample distribution script accordingly

🛠 Implementation details

Compared changes with https://react-native-community.github.io/upgrade-helper/ and implemented the same. Also updated some dependencies to stay compatible.

🎨 UI Changes

NA

🧪 Testing

Run the following command in both the apps and see if the app runs on both platforms.

yarn clean-all && yarn ios && yarn android

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Commits follow the conventional commits spec
  • New code is covered by tests
  • Screenshots added for visual changes
  • Documentation is updated

@santhoshvai santhoshvai requested a review from madsroskar March 9, 2022 15:23
@santhoshvai santhoshvai self-assigned this Mar 9, 2022
@vishalnarkhede vishalnarkhede mentioned this pull request Mar 10, 2022
Merged
6 tasks
khushal87
khushal87 reviewed Mar 11, 2022
View reviewed changes
Copy link
Member

@khushal87 khushal87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things aren't fine with this upgrade in SampleApp and TypeScript messaging app. There are lots of errors and warning which comes up while you try to do pod install. Also, the RCT_folly fails to install and it throws an error to update it. Can you please check?

vishalnarkhede
vishalnarkhede reviewed Mar 11, 2022
View reviewed changes
examples/TypeScriptMessaging/ios/Podfile
@@ -24,5 +24,6 @@ target 'TypeScriptMessaging' do
use_flipper!()
post_install do |installer|
react_native_post_install(installer)
__apply_Xcode_12_5_M1_post_install_workaround(installer)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this backwards compatible btw? I mean will it break for non M1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is backwards compatible and we must keep it. Or else the example apps won't run on M1.
This is a ruby script that runs over all the flipper pods and bumps their respective iOS target to 11.0.

This workaround should in theory be removed in react native once the underlying flipper issue is resolved. Pretty annoying tbh. The issue that @khushal87 faces are also due to some flipper workaround failing.

There is also a patch in 0.68 to resolve a folly issue facebook/react-native@60cef85, which could be related.

@santhoshvai santhoshvai force-pushed the santhosh/update-example-apps-0.67-crns-538 branch from 39308ee to c0e4452 Compare March 11, 2022 20:55
santhoshvai and others added 10 commits March 11, 2022 21:57
@santhoshvai
Merge branch 'develop' into santhosh/update-example-apps-0.67-crns-538
aed4eb8
@santhoshvai
fix: remove bundle install from the bootstrap ci package which is sup…
e5f3067 
…posed to only perform a yarn build
@santhoshvai
feat(workflow): install ruby from version from what is specified in t…
053e66c 
…he sample app
@santhoshvai
chore: make sample distribution workfllow run temporarily on 0.67 bra…
90e081a 
…nch for testing
@santhoshvai
fix(workflow): execute bundle install after installing ruby
ae922f8
@santhoshvai
feat(workflow): add one more step for iOS pod setup
94fd27f
@santhoshvai
fix: xcode project path was incorrect in fast version bump
1ea194c
@santhoshvai
fix: manually update ios version as the last version bump from fastla…
c601e0c 
…ne failed
@santhoshvai
fix: syntax error in fastfile caused the deployment to fail
0358371
[fastlane][ios] Bump version [skip ci]
e2d7e19
@vishalnarkhede vishalnarkhede merged commit e99a8c1 into develop Mar 12, 2022
@vishalnarkhede vishalnarkhede deleted the santhosh/update-example-apps-0.67-crns-538 branch March 12, 2022 20:40
@vishalnarkhede
Copy link
Contributor

🎉 This PR is included in version 4.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khushal87 khushal87 khushal87 left review comments

@vishalnarkhede vishalnarkhede vishalnarkhede approved these changes

@madsroskar madsroskar Awaiting requested review from madsroskar

Assignees

@santhoshvai santhoshvai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@santhoshvai @vishalnarkhede @khushal87