Add CO feature #1384
Merged
Add CO feature #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1384 +/- ##
=======================================
Coverage 96.54% 96.54%
=======================================
Files 613 613
Lines 8735 8735
=======================================
Hits 8433 8433
Misses 302 302
Continue to review full report at Codecov.
|
|
I don't understand the screenshot, isn't the CO feature displaying a value in ppm ? |
|
Unfortunatly no, it's a binay value: do I detect CO? EDIT: according to zigbee2mqtt case. |
|
Oh ok, then we definitely need a proper icon in the UI, or just a text ("Detected"/"Not detected") "1" or "0" is very weird :) |
|
Here a proposal (not pushed yet)
Green == 1 |
atrovato
force-pushed
the
carbon-monoxide-feature
branch
from
03b656d to
649e486
Compare
|
It's better but still it's not perfectly understandable at first sight if you don't know the meaning of this And what about a green/red/grey "badge": ? |
atrovato
force-pushed
the
carbon-monoxide-feature
branch
from
649e486 to
f02d771
Compare
|
So I add a new BinaryDeviceValue component, to manage this kind of display, and a "complex" i18n feature value mapping, with type and category levels (for default cases). This screenshot is for default display |
|
Looks way better now! Good job ! 👏 |
Pierre-Gilles
approved these changes
Dec 3, 2021
Job #166: Bundle Size — 6.66MB (+0.07%).Changed metrics (3/8)
|
atrovato
pushed a commit
to atrovato/Gladys
that referenced
this pull request
Jun 20, 2022
author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645793440 +0100 parent b782865 author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645793419 +0100 parent b782865 author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645793401 +0100 parent b782865 author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645793352 +0100 parent b782865 author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645793338 +0100 parent b782865 author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645793321 +0100 parent b782865 author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645793308 +0100 parent b782865 author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645793277 +0100 parent b782865 author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645792967 +0100 parent b782865 author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645792945 +0100 parent b782865 author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645792308 +0100 parent b782865 author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645792273 +0100 parent b782865 author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645792256 +0100 parent b782865 author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645791714 +0100 parent b782865 author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645791690 +0100 Inital commit Signed-off-by: POCHET Romuald <pochet.romuald@gmail.com> Initail commit Add scheduled jobs in task page Add compare regexp Initial commit Add scheduled jobs in task page Initial commit PR Initial commit PR Remove OZW Missing labels Check calendar event in scene action Prettier Catch bluetooth init error Service folder Remove OZW Update Dockerfile.buildx Update Dockerfile.buildx Update Dockerfile.buildx Update Dockerfile.buildx Update Dockerfile.buildx Update Dockerfile.buildx Update Dockerfile.buildx Disable bluetooth Empty name if no summary for event Move scheduler to scene manager BUG: Error serialization of WEBSOCKET_MESSAGE_TYPES.ZWAVE.NODE_READY Unit tests Prettier Missing Bundle Use regular require Initial commit Tests Integration cover Review configuration BUG: Error serialization of event WEBSOCKET_MESSAGE_TYPES.ZWAVE.NODE_READY Update scene.addScene.js Remove overkiz Update zwave.test.js Update scene.addScene.js Update index.js Tests Update index.test.js Tests Tests Delete overkiz.jpg Clean up Clean up Delete gladys-services/zwave/logs directory Clean up Upgrade zwave-js Rename service folder Clean up Tests Create zwave-js-pr.yml Update index.js Add CO sensor feature (GladysAssistant#1384) * Add CO feature * Add binary graphic Add 44 (Scene Actuator Configuration v0) in config parameters Upgrade ZwaveJS library Delete zwave-js-pr.yml Move service folder to tmp Inital commit Signed-off-by: POCHET Romuald <pochet.romuald@gmail.com> Initail commit Add compare regexp Add scheduled jobs in task page Initial commit Initial commit PR Missing labels Check calendar event in scene action Prettier Catch bluetooth init error Update Dockerfile.buildx Update Dockerfile.buildx Disable bluetooth Empty name if no summary for event Unit tests Missing Bundle Initial commit Tests Integration cover Remove overkiz Tests Delete overkiz.jpg Clean up Clean up Delete gladys-services/zwave/logs directory Clean up Create zwave-js-pr.yml Update index.js Add CO sensor feature (GladysAssistant#1384) * Add CO feature * Add binary graphic Add 44 (Scene Actuator Configuration v0) in config parameters Delete zwave-js-pr.yml Move service folder to tmp Initail commit Add scheduled jobs in task page Add compare regexp Initial commit Add scheduled jobs in task page Initial commit PR Initial commit PR Remove OZW Missing labels Check calendar event in scene action Prettier Catch bluetooth init error Remove OZW Update Dockerfile.buildx Update Dockerfile.buildx Update Dockerfile.buildx Disable bluetooth Empty name if no summary for event Move scheduler to scene manager Unit tests Prettier Missing Bundle Use regular require Initial commit Tests Integration cover Review configuration BUG: Error serialization of event WEBSOCKET_MESSAGE_TYPES.ZWAVE.NODE_READY Update scene.addScene.js Remove overkiz Update scene.addScene.js Update index.js Update index.test.js Tests Delete overkiz.jpg Clean up Clean up Delete gladys-services/zwave/logs directory Clean up Rename service folder Clean up Tests Create zwave-js-pr.yml Update index.js Add CO sensor feature (GladysAssistant#1384) * Add CO feature * Add binary graphic Add 44 (Scene Actuator Configuration v0) in config parameters Delete zwave-js-pr.yml Move service folder to tmp Inital commit Signed-off-by: POCHET Romuald <pochet.romuald@gmail.com> Initail commit Add scheduled jobs in task page Add compare regexp Initial commit Add scheduled jobs in task page Initial commit PR Initial commit PR Remove OZW Remove openzwave build Missing labels Check calendar event in scene action Prettier Catch bluetooth init error Remove OZW Remove OZW Remove OZW Remove OZW Remove OZW Update Dockerfile.buildx Update Dockerfile.buildx Update Dockerfile.buildx Disable bluetooth Empty name if no summary for event Move scheduler to scene manager BUG: Error serialization of WEBSOCKET_MESSAGE_TYPES.ZWAVE.NODE_READY Unit tests Prettier Missing Bundle Initial commit Tests Integration cover Review configuration Update scene.addScene.js Remove overkiz Update scene.addScene.js Update index.js Update index.test.js Tests Delete overkiz.jpg Clean up Clean up Delete gladys-services/zwave/logs directory Clean up Rename service folder Clean up Tests Create zwave-js-pr.yml Update index.js Fix & clean NaN device state (GladysAssistant#1394) Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com> Change 2021 to 2022 in README & LICENSE Add new television category/features (GladysAssistant#1365) Add missing units on switch device (GladysAssistant#1382) Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com> Add icon to vibration binary (GladysAssistant#1386) Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com> Add 44 (Scene Actuator Configuration v0) in config parameters Add 44 (Scene Actuator Configuration v0) in config parameters Delete zwave-js-pr.yml Move service folder to tmp
atrovato
pushed a commit
to atrovato/Gladys
that referenced
this pull request
Jun 20, 2022
author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645793440 +0100 parent b782865 author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645793419 +0100 parent b782865 author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645793401 +0100 parent b782865 author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645793352 +0100 parent b782865 author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645793338 +0100 parent b782865 author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645793321 +0100 parent b782865 author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645793308 +0100 parent b782865 author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645793277 +0100 parent b782865 author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645792967 +0100 parent b782865 author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645792945 +0100 parent b782865 author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645792308 +0100 parent b782865 author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645792273 +0100 parent b782865 author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645792256 +0100 parent b782865 author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645791714 +0100 parent b782865 author POCHET Romuald <pochet.romuald@gmail.com> 1635496602 +0200 committer POCHET Romuald <pochet.romuald@gmail.com> 1645791690 +0100 Inital commit Signed-off-by: POCHET Romuald <pochet.romuald@gmail.com> Initail commit Add scheduled jobs in task page Add compare regexp Initial commit Add scheduled jobs in task page Initial commit PR Initial commit PR Remove OZW Missing labels Check calendar event in scene action Prettier Catch bluetooth init error Service folder Remove OZW Update Dockerfile.buildx Update Dockerfile.buildx Update Dockerfile.buildx Update Dockerfile.buildx Update Dockerfile.buildx Update Dockerfile.buildx Update Dockerfile.buildx Disable bluetooth Empty name if no summary for event Move scheduler to scene manager BUG: Error serialization of WEBSOCKET_MESSAGE_TYPES.ZWAVE.NODE_READY Unit tests Prettier Missing Bundle Use regular require Initial commit Tests Integration cover Review configuration BUG: Error serialization of event WEBSOCKET_MESSAGE_TYPES.ZWAVE.NODE_READY Update scene.addScene.js Remove overkiz Update zwave.test.js Update scene.addScene.js Update index.js Tests Update index.test.js Tests Tests Delete overkiz.jpg Clean up Clean up Delete gladys-services/zwave/logs directory Clean up Upgrade zwave-js Rename service folder Clean up Tests Create zwave-js-pr.yml Update index.js Add CO sensor feature (GladysAssistant#1384) * Add CO feature * Add binary graphic Add 44 (Scene Actuator Configuration v0) in config parameters Upgrade ZwaveJS library Delete zwave-js-pr.yml Move service folder to tmp Inital commit Signed-off-by: POCHET Romuald <pochet.romuald@gmail.com> Initail commit Add compare regexp Add scheduled jobs in task page Initial commit Initial commit PR Missing labels Check calendar event in scene action Prettier Catch bluetooth init error Update Dockerfile.buildx Update Dockerfile.buildx Disable bluetooth Empty name if no summary for event Unit tests Missing Bundle Initial commit Tests Integration cover Remove overkiz Tests Delete overkiz.jpg Clean up Clean up Delete gladys-services/zwave/logs directory Clean up Create zwave-js-pr.yml Update index.js Add CO sensor feature (GladysAssistant#1384) * Add CO feature * Add binary graphic Add 44 (Scene Actuator Configuration v0) in config parameters Delete zwave-js-pr.yml Move service folder to tmp Initail commit Add scheduled jobs in task page Add compare regexp Initial commit Add scheduled jobs in task page Initial commit PR Initial commit PR Remove OZW Missing labels Check calendar event in scene action Prettier Catch bluetooth init error Remove OZW Update Dockerfile.buildx Update Dockerfile.buildx Update Dockerfile.buildx Disable bluetooth Empty name if no summary for event Move scheduler to scene manager Unit tests Prettier Missing Bundle Use regular require Initial commit Tests Integration cover Review configuration BUG: Error serialization of event WEBSOCKET_MESSAGE_TYPES.ZWAVE.NODE_READY Update scene.addScene.js Remove overkiz Update scene.addScene.js Update index.js Update index.test.js Tests Delete overkiz.jpg Clean up Clean up Delete gladys-services/zwave/logs directory Clean up Rename service folder Clean up Tests Create zwave-js-pr.yml Update index.js Add CO sensor feature (GladysAssistant#1384) * Add CO feature * Add binary graphic Add 44 (Scene Actuator Configuration v0) in config parameters Delete zwave-js-pr.yml Move service folder to tmp Inital commit Signed-off-by: POCHET Romuald <pochet.romuald@gmail.com> Initail commit Add scheduled jobs in task page Add compare regexp Initial commit Add scheduled jobs in task page Initial commit PR Initial commit PR Remove OZW Remove openzwave build Missing labels Check calendar event in scene action Prettier Catch bluetooth init error Remove OZW Remove OZW Remove OZW Remove OZW Remove OZW Update Dockerfile.buildx Update Dockerfile.buildx Update Dockerfile.buildx Disable bluetooth Empty name if no summary for event Move scheduler to scene manager BUG: Error serialization of WEBSOCKET_MESSAGE_TYPES.ZWAVE.NODE_READY Unit tests Prettier Missing Bundle Initial commit Tests Integration cover Review configuration Update scene.addScene.js Remove overkiz Update scene.addScene.js Update index.js Update index.test.js Tests Delete overkiz.jpg Clean up Clean up Delete gladys-services/zwave/logs directory Clean up Rename service folder Clean up Tests Create zwave-js-pr.yml Update index.js Fix & clean NaN device state (GladysAssistant#1394) Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com> Change 2021 to 2022 in README & LICENSE Add new television category/features (GladysAssistant#1365) Add missing units on switch device (GladysAssistant#1382) Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com> Add icon to vibration binary (GladysAssistant#1386) Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com> Add 44 (Scene Actuator Configuration v0) in config parameters Add 44 (Scene Actuator Configuration v0) in config parameters Delete zwave-js-pr.yml Move service folder to tmp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
[ ] If your changes affects code, did your write the tests?npm teston both front/server)npm run eslinton both front/server)npm run prettieron both front/server)npm run compare-translationson front)[ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.[ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)[ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Add new CO feature.