Fix NaN device state

[atrovato]

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

• If your changes affects code, did your write the tests?
• Are tests passing? (npm test on both front/server)
• Is the linter passing? (npm run eslint on both front/server)
• Did you run prettier? (npm run prettier on both front/server)
• [ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
• Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
• [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
• [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
• [ ] Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Avoid NaN on device state number value.

Fixes: #1392

[atrovato]

Tested with values in DB, those are well removed on startup.

[codecov]

Codecov Report

Merging #1394 (357498b) into master (f757f99) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1394      +/-   ##
==========================================
- Coverage   96.61%   96.54%   -0.07%     
==========================================
  Files         613      613              
  Lines        8735     8738       +3     
==========================================
- Hits         8439     8436       -3     
- Misses        296      302       +6     

Impacted Files	Coverage Δ
...rver/services/xiaomi/lib/event/xiaomi.onMessage.js	100.00% <ø> (ø)
server/services/zigbee2mqtt/utils/convertValue.js	100.00% <ø> (ø)
server/lib/device/device.saveState.js	100.00% <100.00%> (ø)
server/utils/childProcess.js	66.66% <0.00%> (-33.34%)	⬇️
server/utils/functionsWrapper.js	71.42% <0.00%> (-28.58%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0b8831...357498b. Read the comment docs.

[Pierre-Gilles]

Looks good to me! Just a comment on the Tasmota integration to be sure that we send a Number and not a string

[atrovato]

I think we have a random test

  1) gateway
       gateway.backup
         should backup gladys:
     SequelizeDatabaseError: SQLITE_ERROR: cannot start a transaction within a transaction
      at Query.formatError (node_modules/sequelize/lib/dialects/sqlite/query.js:415:16)
      at Query._handleQueryResponse (node_modules/sequelize/lib/dialects/sqlite/query.js:72:18)
      at Statement.afterExecute (node_modules/sequelize/lib/dialects/sqlite/query.js:246:27)

That's not the 1st I get it.

[Pierre-Gilles]

I often have this one too, but I can't understand which query could be running at the same time 🤷‍♂️

In SQLite you can't run two transactions at the same time (very annoying aha)

[relativeci]

Job #173: Bundle Size — 6.67MB (0%).

4d27c4a vs a0b8831

No changes

---

View Job #173 report on app.relative-ci.com