Skip to content

Commit

Permalink
chore: use a lance fork without the duckdb submodule (#2742)
Browse files Browse the repository at this point in the history
lance uses duckdb as a submodule, and it's a pretty massive repo, `555.9
MB` on a fresh clone. It currently takes absolutely forever to build
glaredb the first time _(or subsequent times if you nuke your cargo
cache)_.

`git clone https://github.com/duckdb/duckdb.git` alone takes almost 4
minutes locally.

this just forks lance and removes the submodule to avoid the problem
alltogether.
  • Loading branch information
universalmind303 authored and tychoish committed Mar 6, 2024
1 parent 6247276 commit cd0faf9
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 22 deletions.
46 changes: 26 additions & 20 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crates/datasources/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ tiberius = { version = "0.12.2", default-features = false, features = [
"rustls",
"chrono",
] }
lance = { git = "https://github.com/lancedb/lance", rev = "310d79eccf93f3c6a48c162c575918cdba13faec" }
lance = { git = "https://github.com/GlareDB/lance", rev = "de6df70d9c5d95a4818b8799c23e3d1ad649bc1d" }
bson = "2.9.0"
scylla = { version = "0.12.0" }
glob = "0.3.1"
Expand Down
2 changes: 1 addition & 1 deletion crates/sqlbuiltins/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ reqwest.workspace = true
# Important to keep this in sync with the datafusion arrow-cast version
arrow-cast = { version = "50.0.0" }

lance-linalg = { git = "https://github.com/lancedb/lance", rev = "310d79eccf93f3c6a48c162c575918cdba13faec" }
lance-linalg = { git = "https://github.com/GlareDB/lance", rev = "de6df70d9c5d95a4818b8799c23e3d1ad649bc1d" }

0 comments on commit cd0faf9

Please sign in to comment.