chore: use a lance fork without the duckdb submodule #2742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tychoish
approved these changes
Mar 5, 2024
tychoish
pushed a commit
that referenced
this pull request
Mar 6, 2024
lance uses duckdb as a submodule, and it's a pretty massive repo, `555.9 MB` on a fresh clone. It currently takes absolutely forever to build glaredb the first time _(or subsequent times if you nuke your cargo cache)_. `git clone https://github.com/duckdb/duckdb.git` alone takes almost 4 minutes locally. this just forks lance and removes the submodule to avoid the problem alltogether.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lance uses duckdb as a submodule, and it's a pretty massive repo,
555.9 MBon a fresh clone. It currently takes absolutely forever to build glaredb the first time (or subsequent times if you nuke your cargo cache).git clone https://github.com/duckdb/duckdb.gitalone takes almost 4 minutes locally.this just forks lance and removes the submodule to avoid the problem alltogether.