Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parameters for read_csv are now wrong #2375

Closed
universalmind303 opened this issue Jan 8, 2024 · 1 comment · Fixed by #2380
Closed

parameters for read_csv are now wrong #2375

universalmind303 opened this issue Jan 8, 2024 · 1 comment · Fixed by #2380
Assignees
@scsmithr
Labels
bug Something isn't working

Comments

@universalmind303
Copy link
Contributor

Description

#2365 changed the signature to now allow a delimiter.

> select distinc function_name, parameters from glare_catalog.functions WHERE function_name = 'read_csv';
┌───────────────┬───────────────────┐
│ function_name │ parameters        │
│ ──            │ ──                │
│ Utf8          │ List<Utf8>        │
╞═══════════════╪═══════════════════╡
│ read_csv      │ [Utf8/List<Utf8>] │
└───────────────┴───────────────────┘
@universalmind303 universalmind303 added the bug Something isn't working label Jan 8, 2024
@scsmithr scsmithr self-assigned this Jan 8, 2024
@scsmithr
Copy link
Member

scsmithr commented Jan 8, 2024

Going to add a headers arg for csv, so will add this in while I'm there.

scsmithr added a commit that referenced this issue Jan 8, 2024
@scsmithr
feat: Allow reading csv files without a header
f97a17a 
```
> select * from read_csv('./testdata/csv/headerless.csv', header => 'false');
┌──────────┬──────────┬──────────┬──────────┐
│ column_1 │ column_2 │ column_3 │ column_4 │
│       ── │ ──       │ ──       │       ── │
│    Int64 │ Utf8     │ Utf8     │  Float64 │
╞══════════╪══════════╪══════════╪══════════╡
│        1 │ hello    │ world    │  3.90000 │
│        2 │ HELLO    │ WORLD    │  4.90000 │
└──────────┴──────────┴──────────┴──────────┘
```

Also does things with the signature. Closes #2375
@scsmithr scsmithr mentioned this issue Jan 8, 2024
Merged
scsmithr added a commit that referenced this issue Jan 8, 2024
@scsmithr @universalmind303
feat: Allow reading csv files without a header (#2380)
f9963d1 
```
> select * from read_csv('./testdata/csv/headerless.csv', header => 'false');
┌──────────┬──────────┬──────────┬──────────┐
│ column_1 │ column_2 │ column_3 │ column_4 │
│       ── │ ──       │ ──       │       ── │
│    Int64 │ Utf8     │ Utf8     │  Float64 │
╞══════════╪══════════╪══════════╪══════════╡
│        1 │ hello    │ world    │  3.90000 │
│        2 │ HELLO    │ WORLD    │  4.90000 │
└──────────┴──────────┴──────────┴──────────┘
```

Also does things with the signature. Closes
#2375

---------

Co-authored-by: universalmind303 <cory.grinstead@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scsmithr scsmithr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Allow reading csv files without a header GlareDB/glaredb
2 participants
@scsmithr @universalmind303