Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow reading csv files without a header #2380

Merged
merged 5 commits into from
Jan 8, 2024
Merged

Conversation

scsmithr
Copy link
Member

@scsmithr scsmithr commented Jan 8, 2024

> select * from read_csv('./testdata/csv/headerless.csv', header => 'false');
┌──────────┬──────────┬──────────┬──────────┐
│ column_1 │ column_2 │ column_3 │ column_4 │
│       ── │ ──       │ ──       │       ── │
│    Int64 │ Utf8     │ Utf8     │  Float64 │
╞══════════╪══════════╪══════════╪══════════╡
│        1 │ hello    │ world    │  3.90000 │
│        2 │ HELLO    │ WORLD    │  4.90000 │
└──────────┴──────────┴──────────┴──────────┘

Also does things with the signature. Closes #2375

```
> select * from read_csv('./testdata/csv/headerless.csv', header => 'false');
┌──────────┬──────────┬──────────┬──────────┐
│ column_1 │ column_2 │ column_3 │ column_4 │
│       ── │ ──       │ ──       │       ── │
│    Int64 │ Utf8     │ Utf8     │  Float64 │
╞══════════╪══════════╪══════════╪══════════╡
│        1 │ hello    │ world    │  3.90000 │
│        2 │ HELLO    │ WORLD    │  4.90000 │
└──────────┴──────────┴──────────┴──────────┘
```

Also does things with the signature. Closes #2375
scsmithr and others added 2 commits January 8, 2024 17:15
Co-authored-by: universalmind303 <cory.grinstead@gmail.com>
@scsmithr scsmithr enabled auto-merge (squash) January 8, 2024 22:29
@scsmithr scsmithr merged commit f9963d1 into main Jan 8, 2024
18 of 19 checks passed
@scsmithr scsmithr deleted the sean/csv-header branch January 8, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parameters for read_csv are now wrong
2 participants