Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Klickhouse fails to convert negative timestamps #2527

Open
vrongmeal opened this issue Jan 30, 2024 · 1 comment
Open

Klickhouse fails to convert negative timestamps #2527

vrongmeal opened this issue Jan 30, 2024 · 1 comment
Assignees
@vrongmeal
Labels
bug Something isn't working

Comments

@vrongmeal
Copy link
Contributor

vrongmeal commented Jan 30, 2024 •
edited
Loading

Description

There are issues with the Klickhouse lib that we use:

https://docs.rs/klickhouse/latest/klickhouse/struct.DynDateTime64.html

This data type stores any time as u64 whereas clickhouse does store negatives (i64). So times like 1900-01-01 00:00:00 cannot be converted (since signed integers are converted to unsigned int).
@vrongmeal vrongmeal added the bug Something isn't working label Jan 30, 2024
@vrongmeal vrongmeal mentioned this issue Jan 30, 2024
Merged
@vrongmeal vrongmeal self-assigned this Jan 31, 2024
@vrongmeal
Copy link
Contributor Author

Plan of action:

  • Create a fork in @GlareDB organization
  • Make changes in the fork
    • Use changes in the fork
    • Raise a PR upstream (hopefully it's accepted)

vrongmeal added a commit that referenced this issue Jan 31, 2024
@vrongmeal
fix: Use actual precision for clickhouse data types (#2528)
b0e49a4 
Related: #2527

---------

Signed-off-by: Vaibhav <vrongmeal@gmail.com>
tychoish pushed a commit that referenced this issue Feb 1, 2024
@vrongmeal @tychoish
fix: Use actual precision for clickhouse data types (#2528)
971dfd2 
Related: #2527

---------

Signed-off-by: Vaibhav <vrongmeal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrongmeal vrongmeal

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vrongmeal