fix: Use actual precision for clickhouse data types #2528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vaibhav <vrongmeal@gmail.com>
tychoish
reviewed
Jan 30, 2024
| for val in column { | ||
| match val { | ||
| Value::DateTime(v) => vals.append_value( | ||
| DateTime::<Tz>::try_from(v) |
There was a problem hiding this comment.
do these conversions work across resolutions too? maybe good to have a comment about their rounding/translation strategy.
There was a problem hiding this comment.
What do you mean by resolutions?
There was a problem hiding this comment.
I think what I'm asking is "what are the cases where the try_from fails? Is it out-of-bounds issues only?
There was a problem hiding this comment.
Yup, it's only out-of-bound cases.
tychoish
approved these changes
Jan 30, 2024
tychoish
pushed a commit
that referenced
this pull request
Feb 1, 2024
Related: #2527 --------- Signed-off-by: Vaibhav <vrongmeal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #2527