Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement pg_catalog.pg_type table #2392

Merged
merged 12 commits into from
Jan 16, 2024

Conversation

universalmind303
Copy link
Contributor

closes #747
closes #2390

Note, I don't think this quite yet closes the other connector issues. Many of them rely on transactions to work properly (such as #1450)

Copy link
Contributor

@tychoish tychoish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any kind of test we should write?

is the nested view stack problem the kind of thing that we should raise with datafusion? It seems like we don't really have enough control or tools to push the stack size back down?

@universalmind303
Copy link
Contributor Author

is there any kind of test we should write?

is the nested view stack problem the kind of thing that we should raise with datafusion? It seems like we don't really have enough control or tools to push the stack size back down?

release already uses different optimizations & removes all debug symbols, so this isn't really an issue outside of development. Since this is something we've already done with our SLT for the exact same reason, it feels reasonable to introduce it here as well.

its really only an issue in develop, and it is a somewhat known one. There are a few issues already open in datafusion wrt SO during planning.

Copy link
Member

@scsmithr scsmithr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Let's add an SLT to assert we can query this without erroring.

@universalmind303 universalmind303 enabled auto-merge (squash) January 16, 2024 16:30
@universalmind303 universalmind303 merged commit 97858e2 into main Jan 16, 2024
19 checks passed
@universalmind303 universalmind303 deleted the universalmind303/pg_type_table branch January 16, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client(psql): stackoverflow in dev build when using tab completion Catalog builtin for pg_type
4 participants