-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move slt runner into main binary #2401
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't be a blocker for this, but I'd still much prefer feature flagging instead of just hiding. While the extra binary size isn't a lot, every little bit slowly adds up.
Since it is exclusively a development feature, it seems natural to feature flag as such.
by my read this shouldn't increase the binary by more than a few kb
let's get it working first 😂 and talk about it on friday. |
Co-authored-by: universalmind303 <cory.grinstead@gmail.com>
Sorry for the really noisy PR, I've been trying to iron and and do a bit of cleanup with the dependencies just in awareness of the binary size. My conclusion generally:
Do folks agree? |
Addresses #2378
See discussion on the ticket.