Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Infer and scan BSON files from file path #2410

Merged
merged 4 commits into from
Jan 14, 2024
Merged

fix: Infer and scan BSON files from file path #2410

merged 4 commits into from
Jan 14, 2024

Conversation

vrongmeal
Copy link
Contributor

Fixes #2409

@vrongmeal
fix: Infer and scan BSON files from file path
d44cd0b 
Fixes #2409

Signed-off-by: Vaibhav <vrongmeal@gmail.com>
@tychoish
Copy link
Contributor

can you add a test case to the pytest?

@greyscaled
Copy link
Contributor

I'd be down for a point release once these fixes go in

@vrongmeal
add test case
b8c793d 
Signed-off-by: Vaibhav <vrongmeal@gmail.com>
@vrongmeal
fix test
352a92d
@vrongmeal
Copy link
Contributor Author

Added test case.

@scsmithr
Copy link
Member 

=========================== short test summary info ============================
FAILED tests/tests/test_bson.py::test_read_bson - psycopg2.errors.InternalError_: Error during planning: unable to infer how to handle file extension: bson
========================= 1 failed, 7 passed in 3.90s ==========================

Binary not being rebuilt?

@tychoish
Copy link
Contributor

Binary not being rebuilt?

yeah, the cache is apparently by cargo.lock hash not the current run...

slt-in-main fixes this.

tychoish
tychoish reviewed Jan 12, 2024
View reviewed changes
Copy link
Contributor

@tychoish tychoish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link #2409

@tychoish
Copy link
Contributor

The build problem should be resolved by the ci changes in #2401

@vrongmeal vrongmeal merged commit c2131a3 into main Jan 14, 2024
19 checks passed
@vrongmeal vrongmeal deleted the vrongmeal/bson-file-path branch January 14, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@universalmind303 universalmind303 universalmind303 approved these changes

@tychoish tychoish tychoish approved these changes

@scsmithr scsmithr Awaiting requested review from scsmithr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot read bson files from location
5 participants
@vrongmeal @tychoish @greyscaled @scsmithr @universalmind303