-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cloud_upload(<filename>)
table func
#2670
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greyscaled
commented
Feb 20, 2024
greyscaled
commented
Feb 20, 2024
greyscaled
changed the title
[WIP] glaredb_upload
feat: Feb 20, 2024
glaredb_upload(<file>)
table func
greyscaled
changed the title
feat:
feat: Feb 20, 2024
glaredb_upload(<file>)
table funcglaredb_upload(<filename>)
table func
greyscaled
commented
Feb 20, 2024
greyscaled
commented
Feb 21, 2024
greyscaled
commented
Feb 21, 2024
greyscaled
commented
Feb 21, 2024
greyscaled
commented
Feb 21, 2024
this all seems good, and I'd be fine merging it.
|
It does and we can easily add that test, I see no harm in it. |
I was moving too quick mostly meant: "a really good error message" and not, say ("credentials not found") or something else. |
This reverts commit c6fc3c0.
greyscaled
commented
Feb 21, 2024
universalmind303
approved these changes
Feb 21, 2024
This reverts commit 78f8c03.
greyscaled
changed the title
feat:
feat: Feb 21, 2024
glaredb_upload(<filename>)
table funccloud_upload(<filename>)
table func
tychoish
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a file is uploaded via GlareDB Cloud, it can be read with
cloud_upload(<filename>)
.This function can only be called in remote and hybrid contexts; it is not meaningful locally.
The
filename
must contain a valid extension (foo.csv
).Example
After uploading a file called
test.csv
to GlareDB Cloud, it can be accessed like:and joined with other data sources, etc.
Details
MVP File Format Limitations
Presently only:
filename.csv
filename.json
are accepted.
The file name must currently include the extension.
The file can only use alphanumeric characters.
Testing
I tested this by building the image and running with a GlareDB Cloud environment.
I think it's tractable to write an integration test for this function, in the same vein
as other integration tests, but I'd prefer to leave this as a follow-up refinement
item.
Resolves: #2614