-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New options added to Pretty Diff #524
Comments
Awesome, thanks @prettydiff ! For anyone interested in making a Pull Request and want to know how:
Try to keep the naming standardized. For example, Atom Beautify should have one way to name an option and it should use beautifier mapps to convert naming of options to JS Beautify and Pretty Diff conventions. |
Just added a new option I am not sure if this will be helpful for you, but I just added support for a |
I think this may be very helpful for users who want to use new Pretty Diff features that Atom Beautify has not yet added support for. Thanks! |
This comment is designed to address #543 and help @abea potentially submit a Pull Request. With some additional thought you could easily implement all of the other options, too. Here's a TODO list that can guide you to create this Pull Request:
That's it! Let me know if you have any questions. |
I just finished up some stuff for work and have a few minutes before I have to leave. I'll try to implement all of these right now 😃. |
Published to v0.28.12:
|
Awesome! |
added pull request for ternary line option #726 |
See #524. Added pretty diff ternaryline option
Any docs that show where to put this file? you mention:
...but this is confusing in the context of Atom. Unless it's only meant to work as a cli tool |
@astanciu Just put everything in the .jsbeautifyrc file. Atom Beautify consolidates all options into that one file. |
I tried that, didn't work for some options. See: |
@prettydiff : The current Pretty Diff beautifier within Atom-Beautify will only apply the options that are explicitly supported: https://github.com/Glavin001/atom-beautify/blob/master/src/beautifiers/prettydiff.coffee#L10-L43 |
For anyone waiting on options, I recommend that you submit a Pull Request yourself. It is very simple. For example: #1193 |
Just a quick FYI. Over the past month or so a couple new options have been added to the Pretty Diff tool:
The text was updated successfully, but these errors were encountered: