-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
See #524. Added support for methodchain setting in prettydiff. #594
Conversation
Whoops, I see that a unit test needs to be updated for the new setting. I'll get that fixed and do another request. |
Oh great. Now the CI tests failed because they couldn't download atom from atom.io. Can someone with permission re-run the CI tests? |
I restarted both CIs. |
Thanks! Not sure why appveyor failed when it reported 0 failures though: On a related question, how do you run tests locally? I tried running |
Running tests locally takes a little work. You have to install everything, including specific Atom packages (such as |
Thank you for contributing! |
Is this in latest release (0.28.16)? I didn't check |
Unfortunately this didn't make it into 28.16. We'll have to wait for the next release. It looks like there's some other major issues going on with prettydiff right now which also need to be fixed though. I still can't use atom-beautify on my jsx files right now. :< |
Published to v0.28.17 |
This is to help address #524 and #591. It looks like the docs were a bit out of date when I ran coffee /docs, so there's some extra
clang-format
support noted in there that's unrelated to this change.