See #524. Added support for methodchain setting in prettydiff.

[hayatae]

This is to help address #524 and #591. It looks like the docs were a bit out of date when I ran coffee /docs, so there's some extra clang-format support noted in there that's unrelated to this change.

[hayatae]

Whoops, I see that a unit test needs to be updated for the new setting. I'll get that fixed and do another request.

[hayatae]

Oh great. Now the CI tests failed because they couldn't download atom from atom.io. Can someone with permission re-run the CI tests?

[Glavin001]

I restarted both CIs.

[hayatae]

Thanks! Not sure why appveyor failed when it reported 0 failures though:
Finished in 16.949 seconds
54 tests, 194 assertions, 0 failures, 0 skipped
Tests failed
Command exited with code 1

On a related question, how do you run tests locally? I tried running apm test in the package root, but I get a whole bunch of errors that look like:
[57512:1009/010335:INFO:CONSOLE(410)] "Could not resolve 'language-svg' to a package path", source: /usr/share/atom/resources/app.asar/src/package-manager.js (410)

[Glavin001]

Running tests locally takes a little work. You have to install everything, including specific Atom packages (such as language-svg as you noted above), and third-party beautifiers with Operating System specific installation instructions, and then run all of the tests for every language and their default supported beautifier. It takes Travis CI under 5 minutes to do all of that.
You can take a look at https://github.com/Glavin001/atom-beautify/blob/master/.travis.yml#L19-L55 and https://github.com/Glavin001/atom-beautify/blob/master/build-package.sh to understand how Travis CI does the tests.

[Glavin001]

Thank you for contributing!

[zachguo]

Is this in latest release (0.28.16)? I didn't check break_chained_methods, but it's still breaking method chains in JSX.

[hayatae]

Unfortunately this didn't make it into 28.16. We'll have to wait for the next release. It looks like there's some other major issues going on with prettydiff right now which also need to be fixed though. I still can't use atom-beautify on my jsx files right now. :<

[Glavin001]

Published to v0.28.17