Fix phpcbf hanging issue by closing stdin #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yesenarman, thanks for your PR! By analyzing the annotation information on this pull request, we identified @ra100 and @UziTech to be potential reviewers |
|
Thank you for contributing! |
|
Published to v0.29.11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This is a fix for issue #893.
There is an issue squizlabs/PHP_CodeSniffer#993 in
phpcbfwhere it hangs when waiting for stdin.The workaround is to close stdin of the child process since it is not being used anyway.
Checklist
Check all those that are applicable and complete.
masterbranch